executor: do not reorder handles when building requests for IndexMergeJoin
#20138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know why |
|
LGTM |
ti-srebot
approved these changes
Sep 22, 2020
qw4990
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@qw4990 merge failed. |
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@qw4990 merge failed. |
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Sep 22, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #20147 |
ti-srebot
pushed a commit
that referenced
this pull request
Oct 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #20137
Problem Summary: executor: do not reorder handles when building requests for
IndexMergeJoinWhat is changed and how it works?
Reordering handles when building requests is for merging successive handles into one, for example
h in (2, 3, 1)can be merged to(h>=1 and h<=3), which may improve the performance.But some handles may overflow, after reordering, they cannot keep the original order.
IndexMergeJoinrequires all rows returned in a specific order, so reordering handles may break this.To avoid this risk, do not reorder handles when building requests for
IndexMergeJoin.Check List
Tests
Release note
IndexMergeJoin