Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: fix inaccurate error info for year column out of range (#18871) #20170

Merged
merged 3 commits into from
Oct 3, 2020
Merged

expression: fix inaccurate error info for year column out of range (#18871) #20170

merged 3 commits into from
Oct 3, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #18871 to release-4.0

What problem does this PR solve?

Issue Number: close #18792

Problem Summary:
Inaccurate error info for year column out of range.

What is changed and how it works?

What's Changed:
Modified return error type as overflow.

Check List

Tests

  • Manual test
tidb> create table t (a year)
tidb> insert into t values(2156)
ERROR 1264 (22003): Out of range value for column 'a' at row 1
  • Unit test

Release note

  • Fix inaccurate error info for year column out of range.

@xiaodong-ji @ti-srebot
cherry pick pingcap#18871 to release-4.0
5baebc0 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Sep 23, 2020
Merged
@ti-srebot ti-srebot added this to the v4.0.7 milestone Sep 23, 2020
@ti-srebot ti-srebot self-assigned this Sep 23, 2020
qw4990
qw4990 reviewed Sep 23, 2020
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 23, 2020
wshwsh12
wshwsh12 reviewed Sep 23, 2020
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 23, 2020
@lzmhhh123 lzmhhh123 modified the milestones: v4.0.7, v4.0.8 Sep 24, 2020
zz-jason
zz-jason approved these changes Oct 3, 2020
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Oct 3, 2020
@zz-jason
Copy link
Member

zz-jason commented Oct 3, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 3, 2020
@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 20297
  • 20293
  • 20155
  • 20074
  • 20252
  • 20240
  • 20248
  • 20249
  • 20216
  • 20154
  • 19944
  • 20210
  • 20205
  • 20214

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit 8a40601 into pingcap:release-4.0 Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 left review comments

@wshwsh12 wshwsh12 wshwsh12 left review comments

@zz-jason zz-jason zz-jason approved these changes

@SunRunAway SunRunAway Awaiting requested review from SunRunAway

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees

@ti-srebot ti-srebot

Labels
component/executor component/expression contribution This PR is from a community contributor. sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT3 The PR has already had 3 LGTM. type/4.0-cherry-pick
Projects
None yet
Milestone
v4.0.8
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-srebot @zz-jason @qw4990 @wshwsh12 @lzmhhh123 @xiaodong-ji