grafana: update kv duration filter condition (#20023) #20260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
/run-all-tests |
|
LGTM |
ti-srebot
added
status/LGT2
jackysp
approved these changes
Sep 28, 2020
|
/merge |
|
Sorry @jackysp, you don't have permission to trigger auto merge event on this branch. |
jackysp
added
challenge-program
status/all-tests-passed
and removed
challenge-program
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #20023 to release-4.0
What problem does this PR solve?
Issue Number: close #20005
What is changed and how it works?
The old condition
type != "GC"is no longer consistent with the current implementation. The requests send by GC workers do not containsStoreIDinformation, so I replacetype != "GC"bystore != "0".Release note
store0