bindinfo: add debugging to plan evolve (#20523) #20530
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #20523 to release-4.0
What problem does this PR solve?
Issue Number: Part of #20417
Problem Summary:
Currently it is very difficult to debug why a new plan is rejected. I believe there is a current bug in the logic, but independently, I've added debugging information and added a threshold of 2x on current execution time just so the error log can contain more stats on the new plan.
What is changed and how it works?
What's Changed:
Rather than timing out a new plan if it won't meet the new query time threshold, an independent threshold is set that is actually longer than the current execution time. This is helpful for debugging purposes.
Related changes
Check List
Tests
Manual tested to see error written to the log when plan was rejected.
Side effects
Release note