Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: add max font size limit #20625

Merged
merged 5 commits into from
Oct 26, 2020

Conversation

crazycs520
Copy link
Contributor

Signed-off-by: crazycs520 crazycs520@gmail.com

What problem does this PR solve?

Close #20624

What is changed and how it works?

Add max font size limit.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Side effects

  • No

Release note

  • Fix issue of generated metric profile failed

Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520 crazycs520 requested a review from a team as a code owner October 25, 2020 14:59
@crazycs520 crazycs520 requested review from wshwsh12 and removed request for a team October 25, 2020 14:59
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@github-actions github-actions bot added sig/sql-infra SIG: SQL Infra sig/execution SIG execution labels Oct 25, 2020
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520
Copy link
Contributor Author

/rebuild

@crazycs520
Copy link
Contributor Author

/run-all-tests

Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 26, 2020
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Oct 26, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Oct 26, 2020
@AilinKid
Copy link
Contributor

AilinKid commented Oct 26, 2020

pls fix the tests

@crazycs520
Copy link
Contributor Author

/run-all-tests

@wshwsh12 wshwsh12 removed their request for review October 26, 2020 05:44
@crazycs520 crazycs520 merged commit c5f3887 into pingcap:master Oct 26, 2020
@crazycs520 crazycs520 deleted the fix-metric-profile branch October 26, 2020 06:15
@crazycs520
Copy link
Contributor Author

/run-cherry-picker

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Oct 26, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #20637

ti-srebot added a commit that referenced this pull request Oct 26, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution sig/sql-infra SIG: SQL Infra status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generate metrics profile error
4 participants