Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: add missing table lock check for fast plan (#20948) #21002

Merged
merged 6 commits into from
Nov 17, 2020
Merged

planner: add missing table lock check for fast plan (#20948) #21002

merged 6 commits into from
Nov 17, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #20948 to release-4.0

What problem does this PR solve?

Issue Number: close #20945

Problem Summary:

when lock table as read update with where statement can update the row.

What is changed and how it works?

What's Changed:

Add table lock check in TryFastPlan code path

Related changes

  • No

Check List

Tests

  • Unit test
  • Integration test
  • Manual test

Manual test step:

create table t (id int, c int);
insert into t values(1, 1), (2, 1);
lock table t read;
update t set c = 2 where id = 2;

Side effects

  • No

Release note

  • Fix table lock for update statement.

@blacktear23 @ti-srebot
cherry pick pingcap#20948 to release-4.0
e1c561d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Nov 12, 2020
Merged
@ti-srebot ti-srebot added this to the v4.0.9 milestone Nov 12, 2020
zz-jason
zz-jason reviewed Nov 12, 2020
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 12, 2020
tangenta
tangenta reviewed Nov 13, 2020
View reviewed changes
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 13, 2020
crazycs520
crazycs520 previously approved these changes Nov 13, 2020
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Nov 13, 2020
@crazycs520
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 13, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@zz-jason
Copy link
Member

/approve

@zz-jason
Copy link
Member

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 20954

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@zz-jason
Copy link
Member

/approve

@zz-jason
Copy link
Member

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 20954

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@ti-srebot ti-srebot added status/LGT4 The PR has already had 4 LGTM. and removed status/LGT3 The PR has already had 3 LGTM. labels Nov 17, 2020
@SunRunAway
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 21073
  • 21073
  • 21019
  • 21055
  • 20413
  • 21074
  • 21045
  • 21050

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit 93ccfca into pingcap:release-4.0 Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@tangenta tangenta tangenta left review comments

@SunRunAway SunRunAway SunRunAway approved these changes

@crazycs520 crazycs520 crazycs520 left review comments

@jackysp jackysp Awaiting requested review from jackysp

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
component/executor status/can-merge Indicates a PR has been approved by a committer. status/LGT4 The PR has already had 4 LGTM. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Milestone
v4.0.9
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-srebot @crazycs520 @zz-jason @SunRunAway @tangenta @blacktear23