Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: support SQL bind for Update / Delete / Insert / Replace (#20686) #21101

Merged
merged 2 commits into from
Nov 30, 2020
Merged

*: support SQL bind for Update / Delete / Insert / Replace (#20686) #21101

merged 2 commits into from
Nov 30, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #20686 to release-4.0

What problem does this PR solve?

Issue Number: close #15827

Problem Summary:

Not a problem, this is an enhancement of SQL bind to support Delete / Update.

What is changed and how it works?

What's Changed:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test: to be added

Side effects

N/A

Release note

  • Support SQL bind for Update / Delete.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Nov 17, 2020
Merged
@ti-srebot ti-srebot added the type/enhancement The issue or PR belongs to an enhancement. label Nov 17, 2020
@ti-srebot ti-srebot added this to the v4.0.9 milestone Nov 17, 2020
@ti-srebot
Copy link
Contributor Author

@eurekaka you're already a collaborator in bot's repo.

@eurekaka eurekaka force-pushed the release-4.0-f72cec77b6cb branch 3 times, most recently from 0c0b6e9 to 45f6216 Compare November 30, 2020 07:21
winoros
winoros reviewed Nov 30, 2020
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 30, 2020
qw4990
qw4990 previously approved these changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 30, 2020
@eurekaka
Copy link
Contributor

/run-all-tests

@eurekaka
Copy link
Contributor

/run-unit-test

@eurekaka
cherry pick pingcap#20686 to release-4.0
1be1206 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@eurekaka
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Nov 30, 2020
@jebter
Copy link

jebter commented Nov 30, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 30, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@eurekaka eurekaka merged commit b793298 into pingcap:release-4.0 Nov 30, 2020
@eurekaka eurekaka deleted the release-4.0-f72cec77b6cb branch November 30, 2020 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros left review comments

@SunRunAway SunRunAway SunRunAway approved these changes

@qw4990 qw4990 qw4990 left review comments

Assignees

@eurekaka eurekaka

Labels
component/executor epic/sql-plan-management sig/execution SIG execution sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT3 The PR has already had 3 LGTM. type/enhancement The issue or PR belongs to an enhancement. type/4.0-cherry-pick
Projects
None yet
Milestone
v4.0.9
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-srebot @eurekaka @jebter @SunRunAway @qw4990 @winoros