Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: check partition name unique when create hash type partition table #21210

Merged
merged 6 commits into from
Nov 24, 2020
Merged

ddl: check partition name unique when create hash type partition table #21210

merged 6 commits into from
Nov 24, 2020

Conversation

xiongjiwei
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #21131

Check List

Tests

  • Unit test

Release note

  • fix a bug that hash type partition does not check partition name is unique

@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Nov 23, 2020
@xiongjiwei xiongjiwei closed this Nov 23, 2020
@xiongjiwei xiongjiwei reopened this Nov 24, 2020
wjhuang2016
wjhuang2016 reviewed Nov 24, 2020
View reviewed changes
Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 24, 2020
@bb7133
Copy link
Member

bb7133 commented Nov 24, 2020

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 24, 2020
bb7133
bb7133 reviewed Nov 24, 2020
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133
Copy link
Member

bb7133 commented Nov 24, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 24, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@xiongjiwei merge failed.

@wjhuang2016
Copy link
Member

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@wjhuang2016
Copy link
Member

/merge

@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 21052

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 7a19c70 into pingcap:master Nov 24, 2020
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Nov 24, 2020
@xiongjiwei @ti-srebot
cherry pick pingcap#21210 to release-4.0
c2af8fc 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Nov 24, 2020
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #21257

ti-srebot added a commit that referenced this pull request Nov 25, 2020
@ti-srebot
ddl: check partition name unique when create hash type partition table (
e8e9e76 
#21210) (#21257)

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@xiongjiwei xiongjiwei deleted the bug-hash-partition branch December 29, 2020 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 left review comments

@wjhuang2016 wjhuang2016 wjhuang2016 left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

Assignees
No one assigned
Labels
sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hash partition does not check partition name is unique
4 participants
@xiongjiwei @bb7133 @ti-srebot @wjhuang2016