Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: check partition name unique when create hash type partition table (#21210) #21257

Merged
merged 3 commits into from
Nov 25, 2020
Merged

ddl: check partition name unique when create hash type partition table (#21210) #21257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c2af8fc
cherry pick #21210 to release-4.0
xiongjiwei Nov 24, 2020
2dab09f
fix test
xiongjiwei Nov 24, 2020
0a7a987
Merge branch 'release-4.0' into release-4.0-7a19c709d07d
ti-srebot Nov 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ddl/db_partition_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,7 @@ func (s *testIntegrationSuite2) TestCreateTableWithHashPartition(c *C) {
PARTITION p1 VALUES LESS THAN (200),
PARTITION p2 VALUES LESS THAN MAXVALUE)`)
tk.MustGetErrCode("select * from t_sub partition (p0)", tmysql.ErrPartitionClauseOnNonpartitioned)
tk.MustGetErrCode("create table t_hash(a int) partition by hash (a) partitions 3 (partition p1, partition p2, partition p2);", tmysql.ErrSameNamePartition)
}

func (s *testIntegrationSuite7) TestCreateTableWithRangeColumnPartition(c *C) {
Expand Down
3 changes: 3 additions & 0 deletions ddl/ddl_api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1699,6 +1699,9 @@ func buildViewInfo(ctx sessionctx.Context, s *ast.CreateViewStmt) (*model.ViewIn

func checkPartitionByHash(ctx sessionctx.Context, tbInfo *model.TableInfo, s *ast.CreateTableStmt) error {
pi := tbInfo.Partition
if err := checkPartitionNameUnique(pi); err != nil {
return err
}
if err := checkAddPartitionTooManyPartitions(pi.Num); err != nil {
return err
}
Expand Down