Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: adjust int constant when compare with year type (#21099) #21283

Merged
merged 7 commits into from
Nov 25, 2020
Merged

expression: adjust int constant when compare with year type (#21099) #21283

merged 7 commits into from
Nov 25, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #21099 to release-4.0

What problem does this PR solve?

Issue Number: close #20305

Problem Summary: when we compare int with year type, and the int could be interpret as year, it should be adjusted.

Note, this change does not work when int is stored as a column, because MySQL does not support this as well.

CREATE TABLE `t3` (`y` year DEFAULT NULL, `a` int DEFAULT NULL);
INSERT INTO `t3` VALUES (2069, 70), (2010, 11), (2155, 2156), (2069, 69);
SELECT * FROM `t3` where y <= a;

MySQL produces

mysql> SELECT * FROM `t3` where y <= a;
+------+------+
| y    | a    |
+------+------+
| 2155 | 2156 |
+------+------+

What is changed and how it works?

What's Changed: add adjust in args refinement.

Related changes

  • Need to cherry-pick to the release branch 4.0, 3.0.

Check List

Tests

  • Integration test

Release note

  • No release note

@ichn-hu @ti-srebot
cherry pick pingcap#21099 to release-4.0
9d0f5b1 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Nov 25, 2020
Merged
@ti-srebot ti-srebot added this to the v4.0.9 milestone Nov 25, 2020
@ti-srebot
Copy link
Contributor Author

@ichn-hu you're already a collaborator in bot's repo.

ichn-hu
ichn-hu approved these changes Nov 25, 2020
View reviewed changes
Copy link
Contributor

@ichn-hu ichn-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 25, 2020
@ichn-hu
Copy link
Contributor

ichn-hu commented Nov 25, 2020

/run-all-tests

lzmhhh123
lzmhhh123 reviewed Nov 25, 2020
View reviewed changes
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 25, 2020
@ti-srebot ti-srebot added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Nov 25, 2020
@SunRunAway
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 25, 2020
@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 21171
  • 21146
  • 21238

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@ichn-hu
Copy link
Contributor

ichn-hu commented Nov 25, 2020

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 21273
  • 21253
  • 21285

@ichn-hu
Copy link
Contributor

ichn-hu commented Nov 25, 2020

/run-all-tests

@ichn-hu
Copy link
Contributor

ichn-hu commented Nov 25, 2020

/merge

@ichn-hu
Copy link
Contributor

ichn-hu commented Nov 25, 2020

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 21282
  • 21282
  • 20413

@ichn-hu
Copy link
Contributor

ichn-hu commented Nov 25, 2020

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 20413

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@ichn-hu
Copy link
Contributor

ichn-hu commented Nov 25, 2020

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 20837

@ichn-hu
Copy link
Contributor

ichn-hu commented Nov 25, 2020

/run-all-tests

1 similar comment
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit 4395275 into pingcap:release-4.0 Nov 25, 2020
This was referenced Dec 14, 2020
Merged
Merged
@seiya-annie seiya-annie mentioned this pull request Feb 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzmhhh123 lzmhhh123 lzmhhh123 left review comments

@SunRunAway SunRunAway SunRunAway approved these changes

@ichn-hu ichn-hu ichn-hu approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

Assignees

@ichn-hu ichn-hu

Labels
component/expression sig/execution SIG execution sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT3 The PR has already had 3 LGTM. type/4.0-cherry-pick
Projects
None yet
Milestone
v4.0.9
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-srebot @ichn-hu @SunRunAway @lzmhhh123