Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix invalid convert type in between...and... (#19820) #21503

Merged
merged 5 commits into from
Dec 11, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #19820 to release-3.0


What problem does this PR solve?

Issue Number: close #11177

Problem Summary:

What is changed and how it works?

  • get correct type for all type conversion in between ... and ...

Tests

  • Unit test

Release note

  • fix an issue that invalid results using BETWEEN...AND... with type conversion

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@xiongjiwei you're already a collaborator in bot's repo.

@xiongjiwei
Copy link
Contributor

@SunRunAway @XuHuaiyu @wjhuang2016 PTAL

Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 11, 2020
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 11, 2020
@xiongjiwei
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 11, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@XuHuaiyu XuHuaiyu merged commit 251478a into pingcap:release-3.0 Dec 11, 2020
@XuHuaiyu XuHuaiyu deleted the release-3.0-1df810744805 branch December 11, 2020 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/3.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants