Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br:backup: If make a backup of empty db, should get a success summary #27467

Merged
merged 9 commits into from
Aug 24, 2021

Conversation

joccau
Copy link
Member

@joccau joccau commented Aug 21, 2021

What problem does this PR solve?

Issue Number: close #27466

Problem Summary:

What is changed and how it works?

What's Changed:
If make a backup for a empty database, return a successful summary result

Tests

  • Manual test (add detailed scripts or steps below)

before fix it

[2021/08/21 12:29:09.666 +08:00] [INFO] [collector.go:66] ["Database backup failed summary"] [total-ranges=0] [ranges-succeed=0] [ranges-failed=0]

after fix it

[2021/08/21 13:42:24.735 +08:00] [INFO] [collector.go:65] ["Database backup success summary"] [total-ranges=0] [ranges-succeed=0] [ranges-failed=0] [total-take=27.584125ms] [BackupTS=427170082246885378]

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 21, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • YuJuncen

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 21, 2021
@joccau
Copy link
Member Author

joccau commented Aug 21, 2021

/component br

@ti-chi-bot ti-chi-bot added the component/br This issue is related to BR of TiDB. label Aug 21, 2021
@joccau
Copy link
Member Author

joccau commented Aug 21, 2021

/build

@joccau
Copy link
Member Author

joccau commented Aug 21, 2021

/cc @3pointer
/cc @YuJuncen
/cc @fengou1
/cc @glorv

@ti-chi-bot
Copy link
Member

@joccau: GitHub didn't allow me to request PR reviews from the following users: YuJuncen.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @3pointer
/cc @YuJuncen
/cc @fengou1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@joccau
Copy link
Member Author

joccau commented Aug 21, 2021

/run-integration-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 23, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 23, 2021
@joccau
Copy link
Member Author

joccau commented Aug 23, 2021

/run-integration-tests

@kennytm
Copy link
Contributor

kennytm commented Aug 23, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 38ff83d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 23, 2021
@joccau
Copy link
Member Author

joccau commented Aug 24, 2021

/run-all-tests

@kennytm
Copy link
Contributor

kennytm commented Aug 24, 2021

/merge

@ti-chi-bot
Copy link
Member

@joccau: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 5516d7d into pingcap:master Aug 24, 2021
@joccau joccau deleted the fix-backup-emptydb branch September 7, 2021 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/br This issue is related to BR of TiDB. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

br: It shows "backup failed" when make a backup of empty DB, but the result $? is 0
5 participants