Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: fix index merge plan when expr cannot be pushed to tikv #30341
planner: fix index merge plan when expr cannot be pushed to tikv #30341
Changes from 6 commits
56bf325
c5d2ddb
c4dc91f
b60786e
4800457
7de60f4
b4654ea
cc74a3e
594b734
bc26b95
5d98c2c
7f00244
eba2cbd
9b4ec81
b59caf3
3630fdb
bc8c836
9187957
b89e269
fb21ec4
19ffe55
e3f3e2e
e249201
cfe8309
f47ebc9
11e5179
887bccd
1d6abd4
b75d087
ff0fb07
8b50eec
a78dc67
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The estRow of
Selection
is defult row count. It's unexpected because its child's estRow is 19.99.Why: IndexMerge's stats is calculated using selectivility of
c1 = 'ab' or c2 = '10'
, and it's stored inpath.CountAfterAccess
. (check #19040). So theds.stats
is not changed. That's why Selection's stat is a defalut value.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we add a new Selection operator, guess we should update newTask's cost?
newTask.addCost(t.count() * sessVars.CPUFactor)
just likePhysicalSelection.attach2Task
did.@winoros