placement: give default 2 followers for non-sugar syntax

ddl/placement/bundle.go

@@ -85,33 +85,24 @@ func NewBundleFromConstraintsOptions(options *model.PlacementSettings) (*Bundle,
 			return nil, fmt.Errorf("%w: LeaderConstraints conflicts with Constraints", err)
 		}
 	}
-	if len(LeaderConstraints) > 0 {
-		Rules = append(Rules, NewRule(Leader, 1, LeaderConstraints))
-	} else if followerCount == 0 {
-		return nil, fmt.Errorf("%w: you must at least provide common/leader constraints, or set some followers", ErrInvalidPlacementOptions)
-	}
+	Rules = append(Rules, NewRule(Leader, 1, LeaderConstraints))
 
-	if followerCount > 0 {
-		// if user did not specify leader, add one
-		if len(LeaderConstraints) == 0 {
-			Rules = append(Rules, NewRule(Leader, 1, NewConstraintsDirect()))
-		}
+	if followerCount == 0 {
+		return nil, fmt.Errorf("%w: you must set some followers", ErrInvalidPlacementOptions)
+	}
 
-		FollowerRules, err := NewRules(Voter, followerCount, followerConstraints)
-		if err != nil {
-			return nil, fmt.Errorf("%w: invalid FollowerConstraints", err)
-		}
-		for _, rule := range FollowerRules {
-			for _, cnst := range CommonConstraints {
-				if err := rule.Constraints.Add(cnst); err != nil {
-					return nil, fmt.Errorf("%w: FollowerConstraints conflicts with Constraints", err)
-				}
+	FollowerRules, err := NewRules(Voter, followerCount, followerConstraints)
+	if err != nil {
+		return nil, fmt.Errorf("%w: invalid FollowerConstraints", err)
+	}
+	for _, rule := range FollowerRules {
+		for _, cnst := range CommonConstraints {
+			if err := rule.Constraints.Add(cnst); err != nil {
+				return nil, fmt.Errorf("%w: FollowerConstraints conflicts with Constraints", err)
 			}
 		}
-		Rules = append(Rules, FollowerRules...)
-	} else if followerConstraints != "" {
-		return nil, fmt.Errorf("%w: specify follower constraints without specify how many followers to be placed", ErrInvalidPlacementOptions)
 	}
+	Rules = append(Rules, FollowerRules...)
 
 	if learnerCount > 0 {
 		LearnerRules, err := NewRules(Learner, learnerCount, learnerConstraints)
@@ -154,9 +145,6 @@ func NewBundleFromSugarOptions(options *model.PlacementSettings) (*Bundle, error
 	}
 
 	followers := options.Followers
-	if followers == 0 {
-		followers = 2
-	}
 	schedule := options.Schedule
 
 	primaryIndex := 0
@@ -217,6 +205,10 @@ func newBundleFromOptions(options *model.PlacementSettings) (bundle *Bundle, err
 		isSyntaxSugar = false
 	}
 
+	if options.Followers == 0 {
+		options.Followers = 2
+	}
+
 	if isSyntaxSugar {
 		bundle, err = NewBundleFromSugarOptions(options)
 	} else {

ddl/placement/bundle_test.go

@@ -572,7 +572,10 @@ func (s *testBundleSuite) TestNewBundleFromOptions(c *C) {
 			LeaderConstraints:   "[+region=as]",
 			FollowerConstraints: "[-region=us]",
 		},
-		err: ErrInvalidPlacementOptions,
+		output: []*Rule{
+			NewRule(Leader, 1, NewConstraintsDirect(NewConstraintDirect("region", In, "as"))),
+			NewRule(Voter, 2, NewConstraintsDirect(NewConstraintDirect("region", NotIn, "us"))),
+		},
 	})
 
 	tests = append(tests, TestCase{