Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: add gctuner to avoid gc frequently #32091

Merged
merged 20 commits into from
Oct 10, 2022
Merged

util: add gctuner to avoid gc frequently #32091

merged 20 commits into from
Oct 10, 2022

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Feb 2, 2022 •
edited
Loading

Signed-off-by: Weizhen Wang wangweizhen@pingcap.com

What problem does this PR solve?

Issue Number: close #32090

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

util: add gctuner to avoid gc frequently.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 2, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Defined2014
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 2, 2022
@hawkingrei hawkingrei changed the title gctuner: add gctuner to avoid gc frequently [DNM] gctuner: add gctuner to avoid gc frequently Feb 2, 2022
@hawkingrei hawkingrei added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 2, 2022
@hawkingrei hawkingrei force-pushed the gctuner branch 2 times, most recently from 3cf3aa8 to 14a9e25 Compare March 19, 2022 16:21
@hawkingrei hawkingrei changed the title [DNM] gctuner: add gctuner to avoid gc frequently util: add gctuner to avoid gc frequently Sep 6, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 6, 2022
@hawkingrei hawkingrei mentioned this pull request Sep 13, 2022
Merged
2 tasks
@hawkingrei hawkingrei requested a review from a team as a code owner September 14, 2022 06:12
@hawkingrei
Copy link
Member Author

/run-build

@hawkingrei
Copy link
Member Author

/run-unit-test

@jianzhiyao
Copy link
Contributor

why not seperate this component as a repo?

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 24, 2022
@hawkingrei
Copy link
Member Author

why not seperate this component as a repo?

This component has an in-depth relationship with tidb. it is in developing.

@hawkingrei
gctuner: add gctuner to avoid gc frequently
aba251f 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
d2b091a
@hawkingrei
update
6116d38
@hawkingrei
update
e377b17 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
clean code
539eab6 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
clean code
388f384 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
clean code
a193b2c 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
clean code
52f1903 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
clean code
a44fb1f 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
*: gctuner
fb2ce8d 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
close set the default value
643717c 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
gctuner
6450604 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
gctuner
b202800 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
Merge branch 'master' into gctuner
7c98247
@hawkingrei
*: fix linter
8ca19b4 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@XuHuaiyu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8ca19b4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 10, 2022
@hawkingrei
Copy link
Member Author

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2022
@hawkingrei
Copy link
Member Author

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2022
@hawkingrei
Copy link
Member Author

/run-build

@ti-chi-bot ti-chi-bot merged commit 8afb7c8 into pingcap:master Oct 10, 2022
@hawkingrei hawkingrei deleted the gctuner branch October 10, 2022 05:03
@sre-bot
Copy link
Contributor

sre-bot commented Oct 10, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/tics-test 🟥 failed 1, success 0, total 1 3 min 38 sec New failing
idc-jenkins-ci-tidb/common-test 🔴 failed 1, success 10, total 11 10 min Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 37 tests passed 32 min Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 30 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 10 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 4 min 30 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 1 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 1 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 43 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Defined2014 Defined2014 Defined2014 approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

@wshwsh12 wshwsh12 wshwsh12 approved these changes

@zimulala zimulala Awaiting requested review from zimulala

@xhebox xhebox Awaiting requested review from xhebox

@qw4990 qw4990 Awaiting requested review from qw4990

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import Semi-Automated GOGC Tuning To Avoid GC Frequently
9 participants
@hawkingrei @ti-chi-bot @jianzhiyao @Benjamin2037 @XuHuaiyu @sre-bot @xhebox @wshwsh12 @Defined2014