Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix CTE predicate pushdown (#33627) #33630

Merged
merged 3 commits into from
Mar 31, 2022
Merged

planner: fix CTE predicate pushdown (#33627) #33630

merged 3 commits into from
Mar 31, 2022

Conversation

wjhuang2016
Copy link
Member

Cherry-pick #33627

Signed-off-by: wjhuang2016 huangwenjun1997@gmail.com

What problem does this PR solve?

Issue Number: close #33622

Problem Summary:
Fix nested CTE predicate pushdown

What is changed and how it works?

Only allow predicate pushdown for outermost CTE.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@wjhuang2016
done
a3407f3 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 31, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • winoros
  • xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 31, 2022
@wjhuang2016
fix
27feece 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@ti-chi-bot
Copy link
Member

@chrysan: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@wjhuang2016
Copy link
Member Author

/run-mysql-test --tidb-test=pr/1648

@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Mar 31, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 31, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 31, 2022
@wjhuang2016
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 358487f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 31, 2022
@wjhuang2016
Copy link
Member Author

/run-mysql-test --tidb-test=pr/1648

@wjhuang2016 wjhuang2016 reopened this Mar 31, 2022
@wjhuang2016
Copy link
Member Author

/run-mysql-test --tidb-test=pr/1648

@wjhuang2016
Copy link
Member Author

/run-mysql-test --tidb-test=pr/1648

@sre-bot
Copy link
Contributor

sre-bot commented Mar 31, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/358487f90dc165e023f0723efc38e5a28b577f31

@wjhuang2016
Copy link
Member Author

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 36a9810 into pingcap:release-6.0 Mar 31, 2022
@VelocityLight VelocityLight added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 1, 2022
@wjhuang2016 wjhuang2016 deleted the fix_cte60 branch November 17, 2022 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrysan chrysan chrysan approved these changes

@guo-shaoge guo-shaoge guo-shaoge approved these changes

@winoros winoros winoros approved these changes

@xiongjiwei xiongjiwei xiongjiwei approved these changes

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@wjhuang2016 @ti-chi-bot @sre-bot @chrysan @guo-shaoge @winoros @xiongjiwei @VelocityLight @zhouqiang-cl