Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: add methods to session.Context and refactor some code about ddl #34699

Merged
merged 7 commits into from
May 30, 2022
Merged

*: add methods to session.Context and refactor some code about ddl #34699

merged 7 commits into from
May 30, 2022

Conversation

xiongjiwei
Copy link
Contributor

@xiongjiwei xiongjiwei commented May 16, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #32031

  • change some mock sessions in the test to real session
  • add 3 methods in sessionctx.Context about txn and disk full
  • refine some codes
    • introduce a interface about job iter

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 16, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 16, 2022
@xiongjiwei
Copy link
Contributor Author

/run-unit-test

@sre-bot
Copy link
Contributor

sre-bot commented May 17, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/db0d21bf21e3b3848c3eff57b22eb22a3b5a8433

zimulala
zimulala reviewed May 17, 2022
View reviewed changes
util/mock/context.go Outdated Show resolved Hide resolved
util/mock/context.go Outdated Show resolved Hide resolved
meta/meta.go Show resolved Hide resolved
ddl/column_test.go Show resolved Hide resolved
sessionctx/context.go Show resolved Hide resolved
xiongjiwei and others added 2 commits May 20, 2022 14:50
@xiongjiwei @zimulala
Update util/mock/context.go
8d473f2 
Co-authored-by: Lynn <zimu_xia@126.com>
@xiongjiwei @zimulala
Update util/mock/context.go
bd92273 
Co-authored-by: Lynn <zimu_xia@126.com>
@xiongjiwei xiongjiwei changed the title *: add methods to session.Context *: add methods to session.Context and refactor some code May 23, 2022
@xiongjiwei xiongjiwei changed the title *: add methods to session.Context and refactor some code *: add methods to session.Context and refactor some code about ddl May 23, 2022
@xiongjiwei xiongjiwei requested a review from zimulala May 23, 2022 06:05
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 23, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 30, 2022
@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: da28cd2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 30, 2022
@ti-chi-bot ti-chi-bot merged commit eb46685 into pingcap:master May 30, 2022
@sre-bot
Copy link
Contributor

sre-bot commented May 30, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🟥 failed 2, success 33, total 35 35 min New failing
idc-jenkins-ci-tidb/integration-ddl-test 🔴 failed 2, success 4, total 6 6 min 55 sec Existing failure
idc-jenkins-ci-tidb/mybatis-test ✅ all 1 tests passed 3 min 28 sec Fixed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 11 tests passed 15 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 11 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 10 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 7 min 3 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 9 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 16 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@xiongjiwei xiongjiwei deleted the master-merge branch September 23, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

@zimulala zimulala Awaiting requested review from zimulala

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support concurrent DDL
6 participants
@xiongjiwei @ti-chi-bot @sre-bot @hawkingrei @zimulala @wjhuang2016