planner: new cost formula for IndexJoin #35671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
…4990/tidb into master-cost-model-2-indexjoin
|
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/c4806574b5447827730c974b11da42d2c51e624a |
AilinKid
reviewed
Jun 23, 2022
| // TODO: estimate it by using index correlation or make it configurable. | ||
| distRatio := 40.0 | ||
| numDoubleReadTasks := (doubleReadRows / batchSize) * distRatio | ||
| return (numDoubleReadTasks * seekFactor) / concurrency |
There was a problem hiding this comment.
do we need to adjust any test cases？
There was a problem hiding this comment.
I'll add some dedicated test cases after finishing cost model ver2.
winoros
approved these changes
Jun 23, 2022
AilinKid
approved these changes
Jun 23, 2022
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: c480657
|
ti-chi-bot
added
the
status/can-merge
TiDB MergeCI notify✅ Well Done! New fixed [1] after this pr merged.
|
morgo
added a commit
to morgo/tidb
that referenced
this pull request
Jun 24, 2022
* upstream/master: (38 commits) planner: disable collate clause support for enum or set column (pingcap#35684) *: Provide a util to "pause" session in uint test (pingcap#35529) ddl: implement the core for multi-schema change (pingcap#35429) parser: XXXDatabaseStmt now use CIStr for DB name (pingcap#35668) *: remove real tikv test on github actions (pingcap#35710) lightning: support disable scheduler by key range (pingcap#34130) Revert "planner: fix the wrong cost formula of MPPExchanger" (pingcap#35707) ddl, owner: refresh ddl sequence cache after becoming the owner (pingcap#35516) store/copr: fix tiflash integration test by disable paging on tiflash (pingcap#35674) planner: new cost formula for IndexJoin (pingcap#35671) BR: fix backup ranges total time summary log (pingcap#35552) raw_restore: fix the issue that raw restore rewrite the t prefix keys (pingcap#35641) table: fix cannot find the temp table when it's created in a transaction (pingcap#35663) metrics: replace histogram with counter for DistSQLCoprCache (pingcap#35514) *: enable exportloopref (pingcap#35680) types: fix bad error message for numeric conversion issue#32744 (pingcap#34047) *: enable ineffassign (pingcap#35670) config, sysvar: map `max-server-connections` to `max_connections` (pingcap#35453) *: enable durationcheck for nogo linter (pingcap#35661) *: fix issue of cast string as time is incompatible with MySQL (pingcap#35455) ...
qw4990
added a commit
to qw4990/tidb
that referenced
this pull request
Jul 12, 2022
qw4990
added a commit
that referenced
this pull request
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #35240
Problem Summary: planner: new cost formula for IndexJoin
What is changed and how it works?
On modelver2, consider double read cost for IndexJoins, which is
numDoubleReadTasks * seekFactor / concurrencyCheck List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.