Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log-backup: fix checkpoint display #36128

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

YuJuncen
Copy link
Contributor

What problem does this PR solve?

Issue Number: fixed #36092

Problem Summary:
Before, if there isn't any checkpoint in the global scope, br log status would display no checkpoints.

What is changed and how it works?

This PR would make us display checkpoint no matter there are some checkpoints.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below) (TBD)
  • No code

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fixed a bug that caused `br log status` returns no checkpoint.

Signed-off-by: Yu Juncen <yujuncen@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 12, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • joccau

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 12, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 12, 2022

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

Copy link
Contributor

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 12, 2022
Copy link
Member

@joccau joccau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 12, 2022
@joccau
Copy link
Member

joccau commented Jul 12, 2022

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jul 12, 2022

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@YuJuncen YuJuncen changed the title fix checkpoint display log_backup: fix checkpoint display Jul 12, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 12, 2022

@joccau joccau changed the title log_backup: fix checkpoint display log-backup: fix checkpoint display Jul 12, 2022
@joccau
Copy link
Member

joccau commented Jul 12, 2022

/run-check_title

@joccau joccau merged commit cbe66a2 into pingcap:6.1.0-pitr-dev Jul 12, 2022
@joccau joccau mentioned this pull request Jul 13, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants