Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

table partition: add telemetry for partition table #36204

Merged
merged 16 commits into from
Jul 22, 2022
Merged

table partition: add telemetry for partition table #36204

merged 16 commits into from
Jul 22, 2022

Conversation

ymkzpx
Copy link
Contributor

@ymkzpx ymkzpx commented Jul 14, 2022

What problem does this PR solve?

Issue Number: close #34949

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 14, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • mjonss
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 14, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 14, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/4c75584fc4c769f5480c3a36143f1c6800099107

@ymkzpx
Copy link
Contributor Author

ymkzpx commented Jul 14, 2022

/cc @mjonss @bb7133 @moyun

@ti-chi-bot ti-chi-bot requested a review from mjonss July 14, 2022 02:52
@ti-chi-bot
Copy link
Member

@ymkzpx: GitHub didn't allow me to request PR reviews from the following users: moyun.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @mjonss @bb7133 @moyun

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot requested a review from bb7133 July 14, 2022 02:52
mjonss
mjonss approved these changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some suggestions and also I wonder if you can come up with more describing names, especially for the name opts of the prometheus counters?

executor/adapter.go Show resolved Hide resolved
telemetry/data.go Show resolved Hide resolved
executor/builder.go Outdated Show resolved Hide resolved
executor/builder.go Outdated Show resolved Hide resolved
executor/builder.go Outdated Show resolved Hide resolved
telemetry/data_feature_usage_test.go Outdated Show resolved Hide resolved
telemetry/data_feature_usage_test.go Outdated Show resolved Hide resolved
executor/adapter.go Outdated Show resolved Hide resolved
metrics/telemetry.go Outdated Show resolved Hide resolved
metrics/telemetry.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 14, 2022
@ymkzpx ymkzpx closed this Jul 15, 2022
@ymkzpx ymkzpx reopened this Jul 15, 2022
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 15, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 15, 2022
tiancaiamao
tiancaiamao reviewed Jul 18, 2022
View reviewed changes
executor/builder.go Show resolved Hide resolved
telemetry/data_feature_usage_test.go Show resolved Hide resolved
telemetry/data_feature_usage.go Show resolved Hide resolved
@ti-chi-bot
Copy link
Member

@ymkzpx: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 19, 2022
tiancaiamao
tiancaiamao approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@tiancaiamao tiancaiamao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this behaviour looks weird to me ... but it's exactly implemented according to the decision made by the PM.
We track the create partition table action instead of the real partition table usage status!

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 21, 2022
@tiancaiamao
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e431dd2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 21, 2022
@ymkzpx ymkzpx closed this Jul 21, 2022
@ymkzpx ymkzpx reopened this Jul 21, 2022
@ymkzpx
Copy link
Contributor Author

ymkzpx commented Jul 21, 2022

/cc @AstroProfundis @lucklove

@ymkzpx ymkzpx closed this Jul 21, 2022
@AstroProfundis
Copy link
Contributor

/lgtm

@ymkzpx ymkzpx reopened this Jul 21, 2022
@ti-chi-bot
Copy link
Member

@AstroProfundis: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ymkzpx
Copy link
Contributor Author

ymkzpx commented Jul 21, 2022

/merge

@ti-chi-bot
Copy link
Member

@ymkzpx: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 21, 2022
@hawkingrei
Copy link
Member

/run-check_dev_2

1 similar comment
@ymkzpx
Copy link
Contributor Author

ymkzpx commented Jul 22, 2022

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit 8bc002e into pingcap:master Jul 22, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 22, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [5] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 2, success 9, total 11 49 min Existing failure
idc-jenkins-ci/integration-cdc-test ✅ all 36 tests passed 35 min Fixed
idc-jenkins-ci-tidb/common-test ✅ all 12 tests passed 22 min Fixed
idc-jenkins-ci-tidb/integration-ddl-test ✅ all 6 tests passed 10 min Fixed
idc-jenkins-ci-tidb/sqllogic-test-1 ✅ all 26 tests passed 8 min 3 sec Fixed
idc-jenkins-ci-tidb/integration-compatibility-test ✅ all 1 tests passed 3 min 12 sec Fixed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 11 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 7 min 53 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 4 min 22 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

morgo added a commit to morgo/tidb that referenced this pull request Jul 22, 2022
@morgo
Merge remote-tracking branch 'upstream/master' into fix-additional-sk…
6b45cb6 
…ip-init

* upstream/master: (125 commits)
  infoschema: fix PromQL for `tidb_distsql_copr_cache` (pingcap#36450)
  test: stabilize TestTopSQLCPUProfile (pingcap#36468)
  parser: add support of 'ADMIN SHOW DDL JOB QUERIES LIMIT m OFFSET n' transferring to AST (pingcap#36285)
  *: enable flaky test for all test (pingcap#36385)
  expression: fix return type of agg func `bit_or` when handling varbinary column (pingcap#36415)
  executor: fix aggregating enum zero value gets different results from mysql  (pingcap#36208)
  server: skip check tiflash version (pingcap#36451)
  *: Minor update to SECURITY.md to improved clarity (pingcap#36346)
  table partition: add telemetry for partition table (pingcap#36204)
  ddl: invalid multiple MAXVALUE partitions (pingcap#36329) (pingcap#36345)
  planner: Fixed `Merge` hint in nested CTE (pingcap#36432)
  metric: impove concurrency ddl metrics (pingcap#36405)
  planner: add more test cases for leading outer join (pingcap#36409)
  ddl: only set concurrent variable if no error (pingcap#36437)
  ddl: fix update panic in the middle of multi-schema change (pingcap#36421)
  session: Mising OptimizeWithPlanAndThenWarmUp in prepare-execute path (pingcap#36347)
  executor,metrics: add a metric for observing execution phases (pingcap#35906)
  br: unified docker image align with tidb (pingcap#36016)
  ddl: skip to close nil sessPool  (pingcap#36425)
  log-backup: remove the timezone from log-date (pingcap#36369)
  ...
morgo added a commit to morgo/tidb that referenced this pull request Jul 22, 2022
@morgo
Merge remote-tracking branch 'upstream/master' into add-bootstrap-sql
08a96f8 
* upstream/master: (280 commits)
  infoschema: fix PromQL for `tidb_distsql_copr_cache` (pingcap#36450)
  test: stabilize TestTopSQLCPUProfile (pingcap#36468)
  parser: add support of 'ADMIN SHOW DDL JOB QUERIES LIMIT m OFFSET n' transferring to AST (pingcap#36285)
  *: enable flaky test for all test (pingcap#36385)
  expression: fix return type of agg func `bit_or` when handling varbinary column (pingcap#36415)
  executor: fix aggregating enum zero value gets different results from mysql  (pingcap#36208)
  server: skip check tiflash version (pingcap#36451)
  *: Minor update to SECURITY.md to improved clarity (pingcap#36346)
  table partition: add telemetry for partition table (pingcap#36204)
  ddl: invalid multiple MAXVALUE partitions (pingcap#36329) (pingcap#36345)
  planner: Fixed `Merge` hint in nested CTE (pingcap#36432)
  metric: impove concurrency ddl metrics (pingcap#36405)
  planner: add more test cases for leading outer join (pingcap#36409)
  ddl: only set concurrent variable if no error (pingcap#36437)
  ddl: fix update panic in the middle of multi-schema change (pingcap#36421)
  session: Mising OptimizeWithPlanAndThenWarmUp in prepare-execute path (pingcap#36347)
  executor,metrics: add a metric for observing execution phases (pingcap#35906)
  br: unified docker image align with tidb (pingcap#36016)
  ddl: skip to close nil sessPool  (pingcap#36425)
  log-backup: remove the timezone from log-date (pingcap#36369)
  ...
joycse06 added a commit to joycse06/tidb that referenced this pull request Jul 23, 2022
@joycse06
Merge remote-tracking branch 'upstream/master' into add-sql-require-p…
1adabd8 
…rimary-key

* upstream/master: (104 commits)
  br: fix compatibility issue with concurrent ddl (pingcap#36474)
  infoschema: fix PromQL for `tidb_distsql_copr_cache` (pingcap#36450)
  test: stabilize TestTopSQLCPUProfile (pingcap#36468)
  parser: add support of 'ADMIN SHOW DDL JOB QUERIES LIMIT m OFFSET n' transferring to AST (pingcap#36285)
  *: enable flaky test for all test (pingcap#36385)
  expression: fix return type of agg func `bit_or` when handling varbinary column (pingcap#36415)
  executor: fix aggregating enum zero value gets different results from mysql  (pingcap#36208)
  server: skip check tiflash version (pingcap#36451)
  *: Minor update to SECURITY.md to improved clarity (pingcap#36346)
  table partition: add telemetry for partition table (pingcap#36204)
  ddl: invalid multiple MAXVALUE partitions (pingcap#36329) (pingcap#36345)
  planner: Fixed `Merge` hint in nested CTE (pingcap#36432)
  metric: impove concurrency ddl metrics (pingcap#36405)
  planner: add more test cases for leading outer join (pingcap#36409)
  ddl: only set concurrent variable if no error (pingcap#36437)
  ddl: fix update panic in the middle of multi-schema change (pingcap#36421)
  session: Mising OptimizeWithPlanAndThenWarmUp in prepare-execute path (pingcap#36347)
  executor,metrics: add a metric for observing execution phases (pingcap#35906)
  br: unified docker image align with tidb (pingcap#36016)
  ddl: skip to close nil sessPool  (pingcap#36425)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AstroProfundis AstroProfundis AstroProfundis approved these changes

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@mjonss mjonss mjonss approved these changes

@bb7133 bb7133 Awaiting requested review from bb7133

@lucklove lucklove Awaiting requested review from lucklove

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add telemetry to table partitioning
7 participants
@ymkzpx @ti-chi-bot @sre-bot @tiancaiamao @AstroProfundis @hawkingrei @mjonss