planner: add binding and recursive test for Merge hint
#36352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I want to insert a hint for CTE-inline, but the Optimizer doesn't find the hint which I code.
only insert some var
I fix my mistake , and remake the hintparser.y
comment on exported type CTEHintInfo should be of the form "CTEHintInfo ..." (with optional leading
fix merge conflict.
try to add a unit test
add cte-hint test(part of them), the cteinlinehint in different cte is coding.
when meet cteinlinehint, open the inline function
support CTEInlineHint in different cte query.
add some parer unit test, ref: TestCTE
make parser
change the hint for CTE name. Old name: CTEInline , New name: Merge. Because we need align with MySQL
test when with recursive,the hint merge is not start
ti-chi-bot
added
size/L
winoros
requested changes
Jul 20, 2022
wjhuang2016
reviewed
Jul 20, 2022
planner/core/logical_plan_builder.go
Outdated
| @@ -3631,6 +3631,11 @@ func (b *PlanBuilder) pushTableHints(hints []*ast.TableOptimizerHint, currentLev | |||
| limitHints.preferLimitToCop = true | |||
| case HintMerge: | |||
| MergeHints.preferMerge = true | |||
| if hint.Tables != nil { | |||
| b.ctx.GetSessionVars().StmtCtx.AppendWarning(ErrInternal.GenWithStack("The MERGE hint is not used correctly, maybe it inputs a table name.")) | |||
| MergeHints.preferMerge = false | |||
There was a problem hiding this comment.
You can put MergeHints.preferMerge = true after L3638, and remove this line.
wjhuang2016
approved these changes
Jul 20, 2022
winoros
approved these changes
Jul 20, 2022
ti-chi-bot
added
status/LGT2
|
@father1111: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 57657c5
|
ti-chi-bot
added
the
status/can-merge
|
/run-unit-test |
1 similar comment
|
/run-unit-test |
TiDB MergeCI notify🔴 Bad News! [2] CI still failing after this pr merged.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #17472
Problem Summary: add binding and recursive test for
Mergehint(#34574 ), and fix some unit test and function.What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.