coprocessor: skip empty tidb nodes

[mornyx]

Issue Number: close #36546

What is changed and how it works?

As described in #36546, we should avoid trying to send coprocessor requests to apparently illegal TiDB addresses. In this PR, our solution is: When building cop tasks, check the node address to decide whether to skip it directly.

Release note

None

Signed-off-by: mornyx mornyx.z@gmail.com

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• crazycs520
• xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[zhongzc]

Can we ignore tidb info with empty IP returned by etcd?

tidb/domain/infosync/info.go

Lines 552 to 563 in 965454f

	func (is *InfoSyncer) getAllServerInfo(ctx context.Context) (map[string]*ServerInfo, error) {
	allInfo := make(map[string]*ServerInfo)
	if is.etcdCli == nil {
	allInfo[is.info.ID] = getServerInfo(is.info.ID, is.info.ServerIDGetter)
	return allInfo, nil
	}
	allInfo, err := getInfo(ctx, is.etcdCli, ServerInformationPath, keyOpDefaultRetryCnt, keyOpDefaultTimeout, clientv3.WithPrefix())
	if err != nil {
	return nil, err
	}
	return allInfo, nil
	}

[xhebox]

Can we ignore tidb info with empty IP returned by etcd?

tidb/domain/infosync/info.go

Lines 552 to 563 in 965454f

	func (is *InfoSyncer) getAllServerInfo(ctx context.Context) (map[string]*ServerInfo, error) {
	allInfo := make(map[string]*ServerInfo)
	if is.etcdCli == nil {
	allInfo[is.info.ID] = getServerInfo(is.info.ID, is.info.ServerIDGetter)
	return allInfo, nil
	}
	allInfo, err := getInfo(ctx, is.etcdCli, ServerInformationPath, keyOpDefaultRetryCnt, keyOpDefaultTimeout, clientv3.WithPrefix())
	if err != nil {
	return nil, err
	}
	return allInfo, nil
	}

I think we can, but I am not sure if we should.

[mornyx]

Can we ignore tidb info with empty IP returned by etcd?

tidb/domain/infosync/info.go

Lines 552 to 563 in 965454f

	func (is *InfoSyncer) getAllServerInfo(ctx context.Context) (map[string]*ServerInfo, error) {
	allInfo := make(map[string]*ServerInfo)
	if is.etcdCli == nil {
	allInfo[is.info.ID] = getServerInfo(is.info.ID, is.info.ServerIDGetter)
	return allInfo, nil
	}
	allInfo, err := getInfo(ctx, is.etcdCli, ServerInformationPath, keyOpDefaultRetryCnt, keyOpDefaultTimeout, clientv3.WithPrefix())
	if err != nil {
	return nil, err
	}
	return allInfo, nil
	}

I can't guarantee whether other code has special dependencies on nodes, even BR nodes. So I just skipped where the problem occurred and didn't modify the entire data source..

[crazycs520]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 0efecb2

[ti-chi-bot]

@mornyx: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

Merge canceled because a new commit is pushed.

[mornyx]

This PR avoids sending copr requests to TiDB nodes with empty IP addresses. Unfortunately, many tests depend on this behavior. When we create a mock store and use it to bootstrap a mock session, all tests will depend on this fact: there is only one node in the entire mocked cluster with an empty IP address and it can handle copr requests normally.

So the optimization of this PR is not easy to achieve, since issue #36546 has been resolved by pr #36558, I will close this PR.