-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: use one shot session to close domain ASAP (#36558) #36594
br: use one shot session to close domain ASAP (#36558) #36594
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@3pointer you're already a collaborator in bot's repo. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/5ba7e959ec82ac3df2b650634c8705dd235ccfe2 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 1481560
|
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
cherry-pick #36558 to release-6.2
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/36594
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: ref #36546
Problem Summary:
when we use
createSession
, the side effect is it will create a domain internally bykv.store
. even if we drop the session the domain still exists during the whole backup. and when the domain exists, it will put an empty ip address node to etcd. this will cause the in-memory cop request slow down.What is changed and how it works?
I add a function to close domain when finished
getGlobalVariable
/getDDLJobs
during backup to reduce the time of hold domain/session during backup.Check List
Tests
before this PR, when BR getting in stuck. we can see two server info keys.
with this PR, when BR getting in stuck. we can see only one server info key and in log we can check the log "one shot domain closed"
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.