Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: make auto-analyze concurrency configurable & push part of order prop to partition table #37421

Merged
merged 4 commits into from
Aug 29, 2022
Merged

*: make auto-analyze concurrency configurable & push part of order prop to partition table #37421

merged 4 commits into from
Aug 29, 2022

Conversation

winoros
Copy link
Member

@winoros winoros commented Aug 28, 2022

What problem does this PR solve?

Issue Number: ref #36108 and #37078

Problem Summary:

pick commits and testing ci

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@winoros
*: make auto-analyze concurrency configurable
c417eb7 
Squashed commit of the following:

commit 541a2900410aab793c25d65846bbe88f9208bb17
Merge: ede49bb a8f524b
Author: Yiding Cui <winoros@gmail.com>
Date:   Sun Aug 28 23:25:32 2022 +0800

    Merge branch 'master' into analyze-concurrency-hotfix

commit ede49bb
Author: wuxiaoju <wuxiaoju@pingcap.com>
Date:   Fri Aug 26 17:07:11 2022 +0800

    fix

commit 9cbd94b
Merge: 41b4c4a b5cbba8
Author: wuxiaoju <wuxiaoju@pingcap.com>
Date:   Fri Aug 26 15:10:24 2022 +0800

    Merge branch 'analyze-concurrency-hotfix' of github.com:chrysan/tidb into analyze-concurrency-hotfix

commit 41b4c4a
Merge: 864bb66 b99aebe
Author: wuxiaoju <wuxiaoju@pingcap.com>
Date:   Fri Aug 26 14:40:16 2022 +0800

    Merge remote-tracking branch 'pingcap/master' into analyze-concurrency-hotfix

commit 864bb66
Merge: 77d372a 21847fe
Author: wuxiaoju <wuxiaoju@pingcap.com>
Date:   Mon Aug 22 23:47:45 2022 +0800

    Merge remote-tracking branch 'pingcap/master' into analyze-concurrency-hotfix

commit 77d372a
Author: wuxiaoju <wuxiaoju@pingcap.com>
Date:   Mon Aug 22 23:45:43 2022 +0800

    make auto-analyze concurrency configurable

commit 3d5577b
Author: wuxiaoju <wuxiaoju@pingcap.com>
Date:   Fri Aug 19 11:58:22 2022 +0800

    Revert "do not limit auto-analyze concurrency too aggressively"

    This reverts commit f1c4198.

commit b5cbba8
Merge: f1c4198 39e00eb
Author: Weizhen Wang <wangweizhen@pingcap.com>
Date:   Mon Aug 15 22:54:04 2022 +0800

    Merge branch 'master' into analyze-concurrency-hotfix

commit f1c4198
Author: wuxiaoju <wuxiaoju@pingcap.com>
Date:   Fri Aug 12 20:11:32 2022 +0800

    do not limit auto-analyze concurrency too aggressively
@winoros
*: support push part of order prop down to partition table
1820eef
@winoros winoros requested a review from a team as a code owner August 28, 2022 15:37
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 28, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • chrysan
  • fixdb

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 28, 2022
@winoros
Copy link
Member Author

winoros commented Aug 28, 2022

/run-unit-test

@sre-bot sre-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 28, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 29, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Aug 29, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/eb1d88c0e146fd51f262417d7a56e64d8c1eeec9

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 29, 2022
@chrysan
Copy link
Contributor

chrysan commented Aug 29, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: eb1d88c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 29, 2022
@ti-chi-bot ti-chi-bot merged commit 7de48a2 into pingcap:release-6.1-20220622 Aug 29, 2022
@xuyifangreeneyes xuyifangreeneyes mentioned this pull request Aug 30, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this pull request Aug 30, 2022
@xuyifangreeneyes
store/copr: fix building cop task for global kill (#37477)
2a51061 
ref #36108, ref #37421
@chrysan chrysan mentioned this pull request Sep 1, 2022
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fixdb fixdb fixdb approved these changes

@chrysan chrysan chrysan approved these changes

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@winoros @ti-chi-bot @sre-bot @chrysan @fixdb