Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: Push down json_contains to tikv #37840

Merged
merged 36 commits into from
Oct 13, 2022
Merged

expression: Push down json_contains to tikv #37840

merged 36 commits into from
Oct 13, 2022

Conversation

lizhenhuan
Copy link
Contributor

@lizhenhuan lizhenhuan commented Sep 15, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #37839

Problem Summary:
Implement json_contains function push down to tikv

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

lizhenhuan and others added 30 commits June 25, 2022 23:29
@lizhenhuan
Merge pull request #1 from pingcap/master
01a0ed1 
Merge master code from pingcap repo
@lizhenhuan
expression: pushdown reverse to TiFlash pingcap#5111
82039a8
@lizhenhuan
Implement Space function push down to TiFlash pingcap#5113
e31bece
@lizhenhuan
Merge pull request #2 from pingcap/master
947b2bc 
Merge from PingCAP Repo
@lizhenhuan
add test case for reverse function push down to tiflash
99af4b5
@lizhenhuan
Merge pull request #3 from pingcap/master
bd05be6 
Merge from pingcap repo
@lizhenhuan
add integration test for reverse
1113574
@lizhenhuan
resolve confict
d4eddfb
@lizhenhuan
Merge branch 'pingcap-master'
70fbbf0
@lizhenhuan
resolve conflict
fbad024
@lizhenhuan
add reverseUTF8 and reverse test case
b51ada5
@lizhenhuan
fix reverse
dc0bae7
@ti-chi-bot
Merge branch 'master' into master
4e63125
@ti-chi-bot
Merge branch 'master' into master
371ebfd
@ti-chi-bot
Merge branch 'master' into master
59eb873
@ti-chi-bot
Merge branch 'master' into master
709ae4e
@lizhenhuan
Merge branch 'space_push_down_5113' into master
d258078
@lizhenhuan
Merge pull request #5 from lizhenhuan/master
26eb1d8 
Merge from master
@lizhenhuan
add space push down to tiflash test case
2155e9f
@lizhenhuan
Merge branch 'master' into space_push_down_5113
c7f6a29
@lizhenhuan
fix code style error
da5dddc
@lizhenhuan
fix space function
5fb1b9b
@lizhenhuan
Merge branch 'master' into space_push_down_5113
6b439df
@lizhenhuan
fix space error
39c62dd
@lizhenhuan
fix space error
d176e1c
@lizhenhuan
Merge branch 'master' into space_push_down_5113
5d6d2f9
@lizhenhuan
Merge branch 'master' into space_push_down_5113
514d1c4
@ti-chi-bot
Merge branch 'master' into space_push_down_5113
ddf9559
@lizhenhuan
Merge pull request #7 from lizhenhuan/master
d63400e 
Merge from PingCAP Repo
@lizhenhuan
implement json_contains push down to tikv
8f343fb
@YangKeao
Copy link
Member

/run-all-tests

@YangKeao
Copy link
Member

/run-mysql-test tidb-test=pr/1991

@YangKeao
Copy link
Member

/run-mysql-test tidb-test=pr/1991

1 similar comment
@YangKeao
Copy link
Member

/run-mysql-test tidb-test=pr/1991

@lizhenhuan
Copy link
Contributor Author

/run-mysql-test tidb-test=pr/1991

YangKeao
YangKeao approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@YangKeao: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@YangKeao
Copy link
Member

/cc @xiongjiwei @xhebox

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 13, 2022
@xiongjiwei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@xiongjiwei: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 13, 2022
@xhebox
Copy link
Contributor

xhebox commented Oct 13, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ca4d430

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 13, 2022
@YangKeao
Copy link
Member

/run-mysql-test tidb-test=pr/1991

@YangKeao
Copy link
Member

/tests

@lizhenhuan
Copy link
Contributor Author

/run-mysql-test tidb-test=pr/1991

@ti-chi-bot ti-chi-bot merged commit a10bb9e into pingcap:master Oct 13, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Oct 13, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [3] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🟥 failed 3, success 14, total 17 12 min New failing
idc-jenkins-ci-tidb/tics-test 🟥 failed 1, success 0, total 1 9 min 9 sec New failing
idc-jenkins-ci-tidb/common-test 🟥 failed 1, success 10, total 11 8 min 46 sec New failing
idc-jenkins-ci/integration-cdc-test 🟢 all 37 tests passed 27 min Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 25 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 27 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 36 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 6 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 36 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YangKeao YangKeao YangKeao approved these changes

@xhebox xhebox xhebox approved these changes

@xiongjiwei xiongjiwei xiongjiwei approved these changes

Assignees

@YangKeao YangKeao

Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support json_contains push down to TiKV
7 participants
@lizhenhuan @ti-chi-bot @mengxin9014 @YangKeao @xiongjiwei @xhebox @sre-bot