Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backup: add checkpoint #38648

Merged
merged 36 commits into from
Nov 30, 2022
Merged

Backup: add checkpoint #38648

merged 36 commits into from
Nov 30, 2022

Conversation

Leavrth
Copy link
Contributor

@Leavrth Leavrth commented Oct 26, 2022 •
edited
Loading

Signed-off-by: Leavrth jianjun.liao@outlook.com

What problem does this PR solve?

Issue Number: close #38647

Problem Summary: add checkpoint for backup

What is changed and how it works?

Record the backed up region information at regular intervals.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Leavrth
draft
cc2aacc 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 26, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • YuJuncen

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 26, 2022
@Leavrth
add unit test
59cd4a8 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
lazy load checkpoint
34615ed 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 27, 2022
@Leavrth
add some annotations
dd1f5ec 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
fix some errors
1f43980 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
Merge branch master into br_checkpoint_v2
dcf9890 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 28, 2022
@Leavrth
backup sub-ranges
93bc6ba 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
fix some errors
d6442eb 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
add checkpoint for checksum
6c70a04 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
Merge branch master into br_checkpoint_v2
dc8ad2e 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
fix some errors
16a2f0c 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 6, 2022
@Leavrth
merge the checkpoint data in each flush
8778474 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
flush checksum of checkpoint in batches
4f82aaa 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
fix unit test
33c7236 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
adjust gc-ttl
84b8b21 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
Merge branch 'master' into br_checkpoint_v2
5be6d69
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 15, 2022
@Leavrth
clear some codes
4fa7d5e 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
add version checker for checkpoint
fc4b7ee 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
add path to error
849227d 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
update summary start time
fa53a6e 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
fix typos
7a61114 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
3pointer
3pointer reviewed Nov 18, 2022
View reviewed changes
br/pkg/task/backup.go Outdated Show resolved Hide resolved
br/pkg/task/backup.go Show resolved Hide resolved
br/pkg/task/backup.go Outdated Show resolved Hide resolved
br/pkg/checkpoint/checkpoint.go Show resolved Hide resolved
br/pkg/checkpoint/checkpoint_test.go Show resolved Hide resolved
@Leavrth Leavrth mentioned this pull request Nov 21, 2022
Merged
15 tasks
@Leavrth
Merge branch master into br_checkpoint_v2
7dea62d 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
checksum for checkpoint checksum info
86b2259 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 23, 2022
@Leavrth
Merge branch master into br_checkpoint_v2
0aed76e 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 23, 2022
@Leavrth
use checkpoint in default
49ee4a5 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
local storage write file to an nonexistent directory
3c2f441 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
fix build error
0ca3a81 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
3pointer
3pointer reviewed Nov 29, 2022
View reviewed changes
br/pkg/task/backup.go Outdated Show resolved Hide resolved
br/pkg/task/backup.go Outdated Show resolved Hide resolved
br/pkg/task/backup.go Show resolved Hide resolved
br/pkg/task/backup.go Outdated Show resolved Hide resolved
@Leavrth
commit some suggestions
53b4925 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 29, 2022
YuJuncen
YuJuncen approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@YuJuncen YuJuncen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

br/pkg/checkpoint/checkpoint.go Outdated Show resolved Hide resolved
br/pkg/checkpoint/checkpoint.go Show resolved Hide resolved
br/pkg/checkpoint/checkpoint.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 29, 2022
joccau
joccau approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@joccau joccau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Leavrth
commit some suggestions
6bec4ee 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
bazel prepare
65105cc 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
Copy link
Contributor Author

Leavrth commented Nov 30, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 65105cc

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 30, 2022
@Leavrth
Copy link
Contributor Author

Leavrth commented Nov 30, 2022

/run-mysql-test

@Leavrth
Copy link
Contributor Author

Leavrth commented Nov 30, 2022

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit 1de2bf6 into pingcap:master Nov 30, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Nov 30, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test ✅ all 17 tests passed 21 min Fixed
idc-jenkins-ci/integration-cdc-test 🟢 all 40 tests passed 24 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 14 min Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 6 min 7 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 56 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 38 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 17 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 5 min 6 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 56 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@Leavrth Leavrth deleted the br_checkpoint_v2 branch January 30, 2023 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3pointer 3pointer 3pointer approved these changes

@YuJuncen YuJuncen YuJuncen approved these changes

@joccau joccau joccau approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Backup: add checkpoint for backup
6 participants
@Leavrth @ti-chi-bot @sre-bot @3pointer @YuJuncen @joccau