DDL: use new PD API to get TiFlash replica table regionCount (#38571) #38732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot
added
release-note-none
12 tasks
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
size/L
VelocityLight
added
cherry-pick-approved
added 2 commits
January 6, 2023 16:19
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
12 tasks
Signed-off-by: hehechen <chentongli@pingcap.com>
ti-chi-bot
added
size/M
|
/cherry-pick-invite |
ti-chi-bot
requested review from
breezewish,
CalvinNeo,
crazycs520 and
windtalker
breezewish
approved these changes
Jan 6, 2023
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 177edee
|
ti-chi-bot
added
the
status/can-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #38571
Signed-off-by: hehechen chentongli@pingcap.com
What problem does this PR solve?
Issue Number: close #38570
Problem Summary:
If the table with TiFlash replica has many regions, such as more than 1 million, the
/pd/api/v1/stats/regioncalled to get region count will bring large overhead to the PD and may affect OLTP workload.What is changed and how it works?
use new PD API
/pd/api/v1/stats/region?countto get TiFlash replica table regionCountCheck List
Tests
Unit test
Integration test
Manual test (add detailed scripts or steps below)
Create table, split 1 million regions, set TiFlash replica 1.
Before modified, flame graph of PD:
After modified, flame graph of PD:
No code
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.