Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autoid_service,meta/autoid: distinguish retriable error from non-retriable error #39215

Merged
merged 10 commits into from
Nov 30, 2022
Merged

autoid_service,meta/autoid: distinguish retriable error from non-retriable error #39215

merged 10 commits into from
Nov 30, 2022

Conversation

tiancaiamao
Copy link
Contributor

@tiancaiamao tiancaiamao commented Nov 17, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #39214

Problem Summary:

When we run sysbench test, and when we run lightning, and also when flashback table ...
The autoid service hang is observed.

What is changed and how it works?

This commit fixes two places:

  1. The previous code does not distinguish the error kind.

When it's a 'not leader' error, the autoid service part return error directly, which become a 'rpc error' by the grpc implementation.
The client will retry on 'rpc error'.

But not all the cases are this kind of error. We should have add the Error field to the kvproto response strucdt field.
For those non-retryable errors, the error should throw to the caller to avoid forever retry.

  1. Set TLS config for grpc client

This may also cause connection fail and forever retry.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 17, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Defined2014
  • hawkingrei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 17, 2022
@tiancaiamao
Copy link
Contributor Author

/run-build-arm64 comment=true

@sre-bot
Copy link
Contributor

sre-bot commented Nov 17, 2022

download tidb binary(linux arm64) at http://fileserver.pingcap.net/download/builds/pingcap/test/tidb/37359bd6f6c0a63f7e428e6d249742f9e397cbc8/centos7/tidb-linux-arm64.tar.gz

@ti-chi-bot ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/needs-triage-completed labels Nov 24, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 28, 2022
@tiancaiamao
Copy link
Contributor Author

/run-build-arm64 comment=true

@sre-bot
Copy link
Contributor

sre-bot commented Nov 28, 2022

download tidb binary(linux arm64) at http://fileserver.pingcap.net/download/builds/pingcap/test/tidb/8673f3adfa4af70716b740eb8fb66dc93ffd0742/centos7/tidb-linux-arm64.tar.gz

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 29, 2022
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 30, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 30, 2022
@tiancaiamao tiancaiamao marked this pull request as ready for review November 30, 2022 01:57
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 30, 2022
Defined2014
Defined2014 reviewed Nov 30, 2022
View reviewed changes
autoid_service/autoid.go Show resolved Hide resolved
go.mod Show resolved Hide resolved
@tiancaiamao
Copy link
Contributor Author

/run-unit-test

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 30, 2022
@tiancaiamao
Copy link
Contributor Author

/run-build
/run-mysql-test

@tiancaiamao
Copy link
Contributor Author

/run-mysql-test

1 similar comment
@hawkingrei
Copy link
Member

/run-mysql-test

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 30, 2022
@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 209f23c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 30, 2022
@tiancaiamao
Copy link
Contributor Author

/run-build

@tiancaiamao
Copy link
Contributor Author

/run-check_dev
/run-check_dev_2
/run-mysql-test

@tiancaiamao
Copy link
Contributor Author

/merge

@tiancaiamao
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit a00f0fe into pingcap:master Nov 30, 2022
@tiancaiamao tiancaiamao deleted the autoid-err branch November 30, 2022 08:41
@sre-bot
Copy link
Contributor

sre-bot commented Nov 30, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [2] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🟥 failed 1, success 39, total 40 26 min New failing
idc-jenkins-ci-tidb/integration-ddl-test 🟥 failed 1, success 5, total 6 5 min 42 sec New failing
idc-jenkins-ci-tidb/tics-test ✅ all 1 tests passed 6 min 9 sec Fixed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 17 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 11 min Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 6 min 30 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 2 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 10 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 13 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@Defined2014 Defined2014 Defined2014 approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

autoid service dead loop
5 participants
@tiancaiamao @ti-chi-bot @sre-bot @hawkingrei @Defined2014