-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br/streamhelper: added timeout for ticking #39625
Conversation
Signed-off-by: hillium <yu745514916@live.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: hillium <yu745514916@live.com>
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 68a14d2
|
In response to a cherrypick label: new pull request created: #39705. |
TiDB MergeCI notify🔴 Bad News! New failing [3] after this pr merged.
|
Signed-off-by: hillium yu745514916@live.com
What problem does this PR solve?
Issue Number: close #39620
Problem Summary:
Sometimes, the receive stream may get stuck when TiKV goes down, and there isn't a timeout for ticking, which may lead to the advancer get stuck, blocking the checkpoint advancing.
What is changed and how it works?
This PR added a timeout valued
10 * TICK_INTERVAL
for ticking.Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.