Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: add retry for prepare flashback for backup cluster is empty and there are only one region (#41059) #41119

Merged

Conversation

fengou1
Copy link
Contributor

@fengou1 fengou1 commented Feb 7, 2023

close #41058

What problem does this PR solve?

Issue Number: close #41058

Problem Summary:
when backup cluster is empty and there is only one region, BR assigned a leader and then do prepare a flashback immediately.
prepare flashback failed when a region was created without a leader.
region heartbeat sent may have some delay (10s), during the prepare flashback, the leader may not be sent heartbeat yet.

What is changed and how it works?

add retry for prepare flashback for specific errors.

Check List

Tests

image

- [ ] No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 7, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • Leavrth

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 7, 2023
@fengou1 fengou1 added the component/br This issue is related to BR of TiDB. label Feb 7, 2023
@fengou1 fengou1 self-assigned this Feb 7, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 7, 2023
@fengou1
Copy link
Contributor Author

fengou1 commented Feb 7, 2023

/merge

@ti-chi-bot
Copy link
Member

@fengou1: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@fengou1
Copy link
Contributor Author

fengou1 commented Feb 7, 2023

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 7, 2023
@fengou1
Copy link
Contributor Author

fengou1 commented Feb 7, 2023

/test build

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 7, 2023
@fengou1
Copy link
Contributor Author

fengou1 commented Feb 7, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e44733a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 7, 2023
@fengou1
Copy link
Contributor Author

fengou1 commented Feb 7, 2023

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 7, 2023
@ti-chi-bot ti-chi-bot merged commit 623f87e into pingcap:release-6.5-20230104-v6.5.0 Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/br This issue is related to BR of TiDB. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants