-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: implement is_ipv4 and is_ipv6 function pushdown #41173
Conversation
support is_ipv4 and is_ipv6 expr to pushdown to tiflash
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Hi @AntiTopQuark. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/run-all-tests |
/ok-to-test |
planner/core/integration_test.go
Outdated
tk.MustExec("insert into t values('123.123.123.123', 'F746:C349:48E3:22F2:81E0:0EA8:E7B6:8286')") | ||
tk.MustExec("insert into t values('0.0.0.0', '0000:0000:0000:0000:0000:0000:0000:0000')") | ||
tk.MustExec("insert into t values('127.0.0.1', '2001:0:2851:b9f0:6d:2326:9036:f37a')") | ||
tk.MustExec("insert into t values('192.168.0.0/10', 'fe80::2dc3:25a5:49a1:6002%24')") | ||
tk.MustExec("insert into t values('192.168.99.22.123', '4207:A33A:58D3:F2C3:8EDC:A548:3EC7:0D00:0D00')") | ||
tk.MustExec("insert into t values('999.999.999.999', '4207:A33A:58D3:F2C3:8EDC:A548::0D00')") | ||
tk.MustExec("insert into t values('3.2.1.', '4207::::8EDC:A548:3EC7:0D00')") | ||
tk.MustExec("insert into t values('3..2.1', '4207:::::A548:3EC7:0D00')") | ||
tk.MustExec("insert into t values('...', '::::::')") | ||
tk.MustExec("insert into t values('4556456', '4556456')") | ||
tk.MustExec("insert into t values('ajdjioa', 'ajdjioa')") | ||
tk.MustExec("insert into t values('', '')") | ||
tk.MustExec("insert into t values(null,null)") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems useless here
planner/core/integration_test.go
Outdated
tk.MustExec("insert into t values('123.123.123.123', 'F746:C349:48E3:22F2:81E0:0EA8:E7B6:8286')") | ||
tk.MustExec("insert into t values('0.0.0.0', '0000:0000:0000:0000:0000:0000:0000:0000')") | ||
tk.MustExec("insert into t values('127.0.0.1', '2001:0:2851:b9f0:6d:2326:9036:f37a')") | ||
tk.MustExec("insert into t values('192.168.0.0/10', 'fe80::2dc3:25a5:49a1:6002%24')") | ||
tk.MustExec("insert into t values('192.168.99.22.123', '4207:A33A:58D3:F2C3:8EDC:A548:3EC7:0D00:0D00')") | ||
tk.MustExec("insert into t values('999.999.999.999', '4207:A33A:58D3:F2C3:8EDC:A548::0D00')") | ||
tk.MustExec("insert into t values('3.2.1.', '4207::::8EDC:A548:3EC7:0D00')") | ||
tk.MustExec("insert into t values('3..2.1', '4207:::::A548:3EC7:0D00')") | ||
tk.MustExec("insert into t values('...', '::::::')") | ||
tk.MustExec("insert into t values('4556456', '4556456')") | ||
tk.MustExec("insert into t values('ajdjioa', 'ajdjioa')") | ||
tk.MustExec("insert into t values('', '')") | ||
tk.MustExec("insert into t values(null,null)") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
/reset |
/test all |
/cc @ywqzzy |
/retest |
/retest |
1 similar comment
/retest |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 2780503
|
/retest |
Please fix case: TestIsIPv6ToTiFlash @AntiTopQuark
|
/reset |
/reset |
Looks like case still failed: @AntiTopQuark
|
You can run |
/test check-dev2 |
@AntiTopQuark: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
thank u very much~ |
it looks like that the test named "check_dev_2" is unstable . |
/test check-dev2 |
What problem does this PR solve?
Issue Number: close #41172
related issue: pingcap/tiflash#6773
Problem Summary:
implement is_ipv4 and is_ipv6 function pushdown
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.