-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: reused table id is disabled when restore a brand-new cluster #41358
Changes from 10 commits
50acd22
139f65f
ac617af
6e0008f
0d85974
effff38
fc757f1
dd7388a
d114b7c
a8dc751
bd2de8a
31fd37f
7ff7752
a4e8c59
84575c9
4694132
594db2b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,147 @@ | ||
// Copyright 2023 PingCAP, Inc. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
package gluetidb | ||
|
||
import ( | ||
"context" | ||
"strconv" | ||
"testing" | ||
|
||
"github.com/pingcap/failpoint" | ||
"github.com/pingcap/tidb/ddl" | ||
"github.com/pingcap/tidb/kv" | ||
"github.com/pingcap/tidb/meta" | ||
"github.com/pingcap/tidb/parser/model" | ||
"github.com/pingcap/tidb/sessionctx" | ||
"github.com/pingcap/tidb/testkit" | ||
"github.com/stretchr/testify/require" | ||
) | ||
|
||
// batch create table with table id reused | ||
func TestSplitBatchCreateTableWithTableId(t *testing.T) { | ||
store, dom := testkit.CreateMockStoreAndDomain(t) | ||
tk := testkit.NewTestKit(t, store) | ||
tk.MustExec("use test") | ||
tk.MustExec("drop table if exists table_id_resued1") | ||
tk.MustExec("drop table if exists table_id_resued2") | ||
tk.MustExec("drop table if exists table_id_new") | ||
|
||
d := dom.DDL() | ||
require.NotNil(t, d) | ||
|
||
infos1 := []*model.TableInfo{} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. and also add a case that There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. add new case in dd7388a |
||
infos1 = append(infos1, &model.TableInfo{ | ||
ID: 124, | ||
Name: model.NewCIStr("table_id_resued1"), | ||
}) | ||
infos1 = append(infos1, &model.TableInfo{ | ||
ID: 125, | ||
Name: model.NewCIStr("table_id_resued2"), | ||
}) | ||
|
||
se := &tidbSession{se: tk.Session()} | ||
|
||
// keep/reused table id verification | ||
tk.Session().SetValue(sessionctx.QueryString, "skip") | ||
|
||
err := se.SplitBatchCreateTable(model.NewCIStr("test"), infos1, ddl.AllocTableIDIf(func(ti *model.TableInfo) bool { | ||
return false | ||
})) | ||
require.NoError(t, err) | ||
|
||
tk.MustQuery("select tidb_table_id from information_schema.tables where table_name = 'table_id_resued1'").Check(testkit.Rows("124")) | ||
tk.MustQuery("select tidb_table_id from information_schema.tables where table_name = 'table_id_resued2'").Check(testkit.Rows("125")) | ||
ctx := kv.WithInternalSourceType(context.Background(), kv.InternalTxnOthers) | ||
|
||
// allocate new table id verification | ||
// query the global id | ||
var id int64 | ||
err = kv.RunInNewTxn(ctx, store, true, func(_ context.Context, txn kv.Transaction) error { | ||
m := meta.NewMeta(txn) | ||
var err error | ||
id, err = m.GenGlobalID() | ||
return err | ||
}) | ||
|
||
require.NoError(t, err) | ||
|
||
infos2 := []*model.TableInfo{} | ||
infos2 = append(infos2, &model.TableInfo{ | ||
ID: 124, | ||
Name: model.NewCIStr("table_id_new"), | ||
}) | ||
|
||
tk.Session().SetValue(sessionctx.QueryString, "skip") | ||
|
||
err = se.SplitBatchCreateTable(model.NewCIStr("test"), infos2, ddl.AllocTableIDIf(func(ti *model.TableInfo) bool { | ||
fengou1 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
return true | ||
})) | ||
require.NoError(t, err) | ||
|
||
idGen, ok := tk.MustQuery("select tidb_table_id from information_schema.tables where table_name = 'table_id_new'").Rows()[0][0].(string) | ||
require.True(t, ok) | ||
idGenNum, err := strconv.ParseInt(idGen, 10, 64) | ||
require.NoError(t, err) | ||
require.Greater(t, idGenNum, id) | ||
|
||
// a empty table info with len(info3) = 0 | ||
infos3 := []*model.TableInfo{} | ||
|
||
err = se.SplitBatchCreateTable(model.NewCIStr("test"), infos3, ddl.AllocTableIDIf(func(ti *model.TableInfo) bool { | ||
return false | ||
})) | ||
require.NoError(t, err) | ||
|
||
} | ||
|
||
// batch create table with table id reused | ||
func TestSplitBatchCreateTable(t *testing.T) { | ||
store, dom := testkit.CreateMockStoreAndDomain(t) | ||
tk := testkit.NewTestKit(t, store) | ||
tk.MustExec("use test") | ||
tk.MustExec("drop table if exists table_1") | ||
tk.MustExec("drop table if exists table_2") | ||
tk.MustExec("drop table if exists table_3") | ||
tk.MustExec("drop table if exists table_4") | ||
tk.MustExec("drop table if exists table_5") | ||
tk.MustExec("drop table if exists table_6") | ||
|
||
d := dom.DDL() | ||
require.NotNil(t, d) | ||
|
||
infos := []*model.TableInfo{} | ||
infos = append(infos, &model.TableInfo{ | ||
Name: model.NewCIStr("tables_1"), | ||
}) | ||
infos = append(infos, &model.TableInfo{ | ||
Name: model.NewCIStr("tables_2"), | ||
}) | ||
infos = append(infos, &model.TableInfo{ | ||
Name: model.NewCIStr("tables_3"), | ||
}) | ||
|
||
se := &tidbSession{se: tk.Session()} | ||
|
||
// keep/reused table id verification | ||
tk.Session().SetValue(sessionctx.QueryString, "skip") | ||
require.NoError(t, failpoint.Enable("github.com/pingcap/tidb/br/pkg/gluetidb/RestoreBatchCreateTableEntryTooLarge", "return(true)")) | ||
err := se.SplitBatchCreateTable(model.NewCIStr("test"), infos, ddl.AllocTableIDIf(func(ti *model.TableInfo) bool { | ||
return true | ||
})) | ||
|
||
require.NoError(t, err) | ||
|
||
require.NoError(t, failpoint.Disable("github.com/pingcap/tidb/br/pkg/gluetidb/RestoreBatchCreateTableEntryTooLarge")) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can we add a check that id has reused? |
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.