Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: lock the temp index key properly in DML #41516

Merged
merged 4 commits into from
Feb 17, 2023
Merged

*: lock the temp index key properly in DML #41516

merged 4 commits into from
Feb 17, 2023

Conversation

tangenta
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #41515

Problem Summary:

What is changed and how it works?

  • Add the unique check for temp index in keyNeedToLock()
  • Refine some of the function parameters

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 16, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Benjamin2037
  • hawkingrei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed labels Feb 16, 2023
@tangenta tangenta added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Feb 16, 2023
@tangenta tangenta changed the title *: fix temp index key does not lock properly *: lock the temp index key properly in DML Feb 16, 2023
@tangenta
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 17, 2023
@hawkingrei
Copy link
Member

/test unit-test

Benjamin2037
Benjamin2037 approved these changes Feb 17, 2023
View reviewed changes
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 17, 2023
wjhuang2016
wjhuang2016 reviewed Feb 17, 2023
View reviewed changes
tablecodec/tablecodec.go
@@ -1058,6 +1058,9 @@ func IsUntouchedIndexKValue(k, v []byte) bool {
return false
}
vLen := len(v)
if IsTempIndexKey(k) {
return vLen > 0 && v[vLen-1] == kv.UnCommitIndexKVFlag
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the UnCommitIndexKVFlag be the value itself?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, temp index values always end with 'b'/'m'/'d'/'1'.

@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2674308

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 17, 2023
@ti-chi-bot ti-chi-bot merged commit bc95a4f into pingcap:master Feb 17, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 17, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #41546.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Feb 17, 2023
@tangenta @ti-chi-bot
This is an automated cherry-pick of pingcap#41516
db51853 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot added a commit that referenced this pull request Feb 23, 2023
@ti-chi-bot
*: lock the temp index key properly in DML (#41516) (#41546)
2bc478f 
close #41515
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pessimistic lock not found when adding index
5 participants
@tangenta @ti-chi-bot @hawkingrei @Benjamin2037 @wjhuang2016