Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: prepare grouping function for roll up #42464

Merged
merged 24 commits into from
Apr 27, 2023

Conversation

xzhangxian1008
Copy link
Contributor

@xzhangxian1008 xzhangxian1008 commented Mar 22, 2023

What problem does this PR solve?

Issue Number: close #42463

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 22, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AilinKid
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 22, 2023
@xzhangxian1008
Copy link
Contributor Author

xzhangxian1008 commented Mar 22, 2023

/cc @windtalker @AilinKid

@ti-chi-bot
Copy link
Member

@xzhangxian1008: GitHub didn't allow me to request PR reviews from the following users: Arenatlx.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @windtalker @arenatlx

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xzhangxian1008
Copy link
Contributor Author

/cc @AilinKid

@Defined2014
Copy link
Contributor

Defined2014 commented Mar 23, 2023

Please fix TestShowBuiltin test

expression/builtin_grouping.go Outdated Show resolved Hide resolved
expression/builtin_grouping.go Outdated Show resolved Hide resolved
expression/builtin_grouping.go Outdated Show resolved Hide resolved
expression/builtin_grouping.go Outdated Show resolved Hide resolved
@AilinKid
Copy link
Contributor

you can link your pb pull request here.

@xzhangxian1008
Copy link
Contributor Author

you can link your pb pull request here.

okk, I have put it on the top field

@xzhangxian1008
Copy link
Contributor Author

Please fix TestShowBuiltin test

okk

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 9, 2023
@xzhangxian1008
Copy link
Contributor Author

/cc @guo-shaoge

@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 14, 2023
DEPS.bzl Outdated
@@ -3402,8 +3402,9 @@ def go_deps():
name = "com_github_pingcap_tipb",
build_file_proto_mode = "disable_global",
importpath = "github.com/pingcap/tipb",
sum = "h1:CeeMOq1aHPAhXrw4eYXtQRyWOFlbfqK1+3f9Iop4IfU=",
version = "v0.0.0-20230310043643-5362260ee6f7",
replace = "github.com/pingcap/tipb",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the replace = xxxx needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the replace = xxxx needed?

I will delete it before merge.

expression/builtin_grouping.go Outdated Show resolved Hide resolved
expression/builtin_grouping.go Outdated Show resolved Hide resolved
@xzhangxian1008
Copy link
Contributor Author

/cc @windtalker

@ti-chi-bot ti-chi-bot bot requested a review from windtalker April 26, 2023 08:51
expression/builtin.go Outdated Show resolved Hide resolved
expression/builtin_grouping.go Show resolved Hide resolved
expression/builtin_grouping.go Outdated Show resolved Hide resolved
expression/builtin_grouping.go Outdated Show resolved Hide resolved
expression/builtin_grouping.go Outdated Show resolved Hide resolved
expression/builtin_grouping.go Show resolved Hide resolved
@xzhangxian1008
Copy link
Contributor Author

/cc @windtalker

@ti-chi-bot ti-chi-bot bot requested a review from windtalker April 27, 2023 03:15
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM

}

func (b *builtinGroupingImplSig) checkMetadata() error {
mode := b.getGroupingMode()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should check isMetaInited first

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should check isMetaInited first

okk

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 27, 2023
@xzhangxian1008
Copy link
Contributor Author

/retest

@AilinKid
Copy link
Contributor

/retest

@AilinKid
Copy link
Contributor

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 27, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 7b56e4d

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 27, 2023
@ti-chi-bot ti-chi-bot bot merged commit 4e30d7b into pingcap:master Apr 27, 2023
@xzhangxian1008 xzhangxian1008 deleted the grouping branch April 27, 2023 10:39
yahonda added a commit to yahonda/tidb that referenced this pull request Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare grouping function for roll up
5 participants