Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: set lossy DDL change source for column worker #43232

Merged
merged 12 commits into from
Apr 26, 2023

Conversation

Rustin170506
Copy link
Member

@Rustin170506 Rustin170506 commented Apr 20, 2023

What problem does this PR solve?

Issue Number: close #43227

Problem Summary:

What is changed and how it works?

set lossy DDL change source for column worker
See more at the issue.

Check List

Tests

  • Unit test

Side effects

None

Documentation

None

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 20, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lichunzhu
  • zimulala

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 20, 2023
kv/option.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 20, 2023
@Rustin170506 Rustin170506 marked this pull request as ready for review April 20, 2023 08:24
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 20, 2023
@Rustin170506
Copy link
Member Author

Test it locally:

  1. Build new version TiDB and TiKV
  2. Start tidb cluster tiup playground nightly --tiflash 0 --kv.binpath /Users/hi-rustin/vsc/tikv/target/debug/tikv-server --db.binpath /Users/hi-rustin/GolandProjects/tidb/bin/tidb-server
  3. Start TiCDC cluster and create blackhole changefeed: ./cdc cli changefeed create --sink-uri="blackhole://" -c test
  4. Check the log try to find BlackHoleSink: WriteEvents
  5. Only find one record: [2023/04/21 15:46:01.839 +08:00] [INFO] [black_hole_dml_sink.go:38] ["BlackHoleSink: WriteEvents"] [row="{\"start-ts\":440942765231308803,\"commit-ts\":440942765231308804,\"row-id\":1,\"table\":{\"db-name\":\"test\",\"tbl-name\":\"example\",\"tbl-id\":88,\"is-partition\":false},\"column-infos\":[{\"ID\":1,\"IsPKHandle\":true,\"VirtualGenCol\":false,\"Ft\":{\"Tp\":3,\"Flag\":4099,\"Flen\":11,\"Decimal\":0,\"Charset\":\"binary\",\"Collate\":\"binary\",\"Elems\":null,\"ElemsIsBinaryLit\":null,\"Array\":false}},{\"ID\":2,\"IsPKHandle\":false,\"VirtualGenCol\":false,\"Ft\":{\"Tp\":3,\"Flag\":0,\"Flen\":11,\"Decimal\":0,\"Charset\":\"binary\",\"Collate\":\"binary\",\"Elems\":null,\"ElemsIsBinaryLit\":null,\"Array\":false}}],\"columns\":[{\"name\":\"id\",\"type\":3,\"charset\":\"binary\",\"flag\":11,\"value\":1,\"default\":null},{\"name\":\"b\",\"type\":3,\"charset\":\"binary\",\"flag\":65,\"value\":1,\"default\":null}],\"pre-columns\":null}"]

Copy link
Member Author

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self check

ddl/column.go Show resolved Hide resolved
session/session.go Show resolved Hide resolved
kv/option.go Outdated Show resolved Hide resolved
kv/option.go Outdated Show resolved Hide resolved
kv/option_test.go Outdated Show resolved Hide resolved
@Rustin170506 Rustin170506 requested review from zimulala and removed request for nongfushanquan April 25, 2023 08:10
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 25, 2023
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 26, 2023
@lichunzhu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 26, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 8a6dc90

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 26, 2023
@ti-chi-bot ti-chi-bot bot merged commit a64b149 into pingcap:master Apr 26, 2023
@Rustin170506 Rustin170506 added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels May 5, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #43548.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #43549.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore lossy DDL change for TiCDC
5 participants