Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: upgrade cloud.google.com/go/storage to v1.30.1 #43382

Merged
merged 1 commit into from
Apr 25, 2023
Merged

*: upgrade cloud.google.com/go/storage to v1.30.1 #43382

merged 1 commit into from
Apr 25, 2023

Conversation

bb7133
Copy link
Member

@bb7133 bb7133 commented Apr 25, 2023

What problem does this PR solve?

Issue Number: N/A

Problem Summary:

Simply upgrade cloud.google.com/go/storage to v1.30.1(the latest release version).

For some reason I can't figure out, the current TiDB gives me the following error when compiling with make server:

# cloud.google.com/go/storage
../../../../pkg/mod/cloud.google.com/go/storage@v1.28.1/client.go:99:85: undefined: HMACKey
../../../../pkg/mod/cloud.google.com/go/storage@v1.28.1/client.go:100:119: undefined: HMACKeysIterator
../../../../pkg/mod/cloud.google.com/go/storage@v1.28.1/client.go:101:91: undefined: HMACKeyAttrsToUpdate
../../../../pkg/mod/cloud.google.com/go/storage@v1.28.1/client.go:101:138: undefined: HMACKey
../../../../pkg/mod/cloud.google.com/go/storage@v1.28.1/client.go:102:99: undefined: HMACKey
../../../../pkg/mod/cloud.google.com/go/storage@v1.28.1/grpc_client.go:1110:112: undefined: HMACKey
../../../../pkg/mod/cloud.google.com/go/storage@v1.28.1/grpc_client.go:1131:146: undefined: HMACKeysIterator
../../../../pkg/mod/cloud.google.com/go/storage@v1.28.1/grpc_client.go:1175:118: undefined: HMACKeyAttrsToUpdate
../../../../pkg/mod/cloud.google.com/go/storage@v1.28.1/grpc_client.go:1175:165: undefined: HMACKey
../../../../pkg/mod/cloud.google.com/go/storage@v1.28.1/grpc_client.go:1210:126: undefined: HMACKey
../../../../pkg/mod/cloud.google.com/go/storage@v1.28.1/grpc_client.go:1210:126: too many errors
make: *** [server] Error 1

This can be solved by upgrading cloud.google.com/go/storage, IMHO it should be fine to do so.

Check List

Tests

  • No code

Side effects

  • None

Documentation

  • None

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 25, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 25, 2023
@bb7133 bb7133 added skip-issue-check Indicates that a PR no need to check linked issue. and removed do-not-merge/needs-linked-issue labels Apr 25, 2023
hawkingrei
hawkingrei reviewed Apr 25, 2023
View reviewed changes
go.mod Show resolved Hide resolved
@bb7133 bb7133 requested a review from lance6716 April 25, 2023 05:29
lance6716
lance6716 approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to address comment, rest lgtm

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 25, 2023
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 25, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 25, 2023
@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 25, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 3fb2db5

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 25, 2023
@ti-chi-bot ti-chi-bot bot merged commit f64cc69 into master Apr 25, 2023
@ti-chi-bot ti-chi-bot bot deleted the bb7133/up_go_storage branch April 25, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bb7133 @hawkingrei @lance6716