Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loaddata: revert concurrent writing to TiKV and WITH detached #44056

Merged
merged 7 commits into from
May 23, 2023
Merged

loaddata: revert concurrent writing to TiKV and WITH detached #44056

merged 7 commits into from
May 23, 2023

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented May 22, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #44078

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@lance6716
loaddata: revert concurrent writing to TiKV
c234398 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 22, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • D3Hunter
  • GMHDBJD

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 22, 2023
@lance6716
fix bazel_prepare
76e47bb 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
fix lint
b0a4b5a 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
fix missing warning
0445238 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
remove WITH detached
daf2edd 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716 lance6716 changed the title loaddata: revert concurrent writing to TiKV loaddata: revert concurrent writing to TiKV and WITH detached May 22, 2023
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 22, 2023
D3Hunter
D3Hunter reviewed May 23, 2023
View reviewed changes
Copy link
Contributor

@D3Hunter D3Hunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

tests/realtikvtest/loaddatatest/detach_test.go Outdated
@@ -1,108 +0,0 @@
// Copyright 2023 PingCAP, Inc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can keep this, will change it in IMPORT INTO

tests/realtikvtest/loaddatatest/one_parquet_test.go Outdated
"github.com/stretchr/testify/require"
)

//go:embed test.parquet
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this too

tests/realtikvtest/loaddatatest/test.parquet Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diitto

@lance6716
address comment
aa7b766 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 23, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 23, 2023
@niubell niubell requested a review from GMHDBJD May 23, 2023 05:52
GMHDBJD
GMHDBJD approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 23, 2023
@lance6716
fix bazel
56ec756 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 23, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 56ec756

@ti-chi-bot ti-chi-bot bot added status/can-merge Indicates a PR has been approved by a committer. and removed do-not-merge/needs-linked-issue labels May 23, 2023
@ti-chi-bot ti-chi-bot bot merged commit 0ac7473 into pingcap:master May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@D3Hunter D3Hunter D3Hunter approved these changes

@GMHDBJD GMHDBJD GMHDBJD approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lance6716 @D3Hunter @GMHDBJD