Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl, test: fix data race in owner change test #44536

Merged
merged 2 commits into from
Jun 9, 2023
Merged

ddl, test: fix data race in owner change test #44536

merged 2 commits into from
Jun 9, 2023

Conversation

ywqzzy
Copy link
Contributor

@ywqzzy ywqzzy commented Jun 9, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #44534

Problem Summary:
In mock owner change test, ddlSeqNum can be write which introduce data race, add lock to protect it.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 9, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 9, 2023
@tangenta
Copy link
Contributor

tangenta commented Jun 9, 2023

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 9, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 9, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-09 03:00:01.2408587 +0000 UTC m=+53615.488780520: ☑️ agreed by tangenta.
  • 2023-06-09 03:19:34.005445574 +0000 UTC m=+54788.253367401: ☑️ agreed by hawkingrei.

zimulala
zimulala approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, tangenta, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,tangenta,zimulala]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 1061ed2 into pingcap:master Jun 9, 2023
@Defined2014 Defined2014 mentioned this pull request Jun 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@zimulala zimulala zimulala approved these changes

@tangenta tangenta tangenta approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DATA RACE at the ddl.(*worker).writeDDLSeqNum
4 participants
@ywqzzy @tangenta @hawkingrei @zimulala