-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: fix 'duplicate entry' error when using br to restore AUTO_ID_CACHE=1 tables #44743
Conversation
/retest-required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FAILED ddl.TestAutoIncrementForceAutoIDCache
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Leavrth, xhebox The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/merge |
/retest unit-test CI unit test fail on #44800 |
@tiancaiamao: The
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test unit-test |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
/run-cherry-picker |
What problem does this PR solve?
Issue Number: close #44716, ref #38442
Problem Summary:
#39041 use separate allocator for row id and auto id.
That is some kind of compatibility-break, although it handle the backword-compatibility carefully in the tidb side, I still miss something in the br component.
When br backup a table with auto increment column, it get the row id allocator from the meta key. It should have used the auto increment id allocator after #39041
What is changed and how it works?
The auto increment meta key of a table with AUTO_ID_CACHE=1 option is a separated one, rather than the row ID meta key.
Check List
Tests
The steps descripted in #44716
I do think some integration test is necessory for this commit.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.