restore: precheck cluster is empty when first time full restore #45014
Conversation
|
Skipping CI for Draft Pull Request. |
ti-chi-bot
bot
added
needs-cherry-pick-release-5.4
|
/run-integration-br-tests |
|
Hi @3pointer. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
/run-integration-br-tests |
|
/run-integration-br-tests |
1 similar comment
|
/run-integration-br-tests |
|
/run-integration-br-tests |
|
/ok-to-test |
|
/run-integration-br-tests |
|
/ok-to-test |
|
/run-integration-br-tests |
ti-chi-bot
bot
added
the
needs-cherry-pick-release-5.3
|
/ok-to-test |
|
/run-integration-br-tests |
|
/run-integration-br-tests |
ti-chi-bot
bot
added
approved
release-note
3pointer
added
release-note-none
ti-chi-bot
bot
removed
the
release-note-none
| if isFullRestore(cmdName) { | ||
| // we need check cluster is fresh every time. except restore from a checkpoint. | ||
| if client.IsFull() && len(checkpointSetWithTableID) == 0 { | ||
| if err = client.CheckTargetClusterFresh(ctx); err != nil { |
There was a problem hiding this comment.
This will make BR fail once there are any table in the cluster. (Even there isn't intersection of them and the backup archive.) Will this break some use cases?
There was a problem hiding this comment.
Yes, It's intended @benmaoer has confirmed it. so this behaviour will introduced in v7.3. and won't cherry-pick back to any release versions.
There was a problem hiding this comment.
Yes, there are 2 options:
-
When restoring the entire cluster from a full backup, it is necessary to check whether the target cluster is an empty cluster, which has no user tables.
-
When restoring specific tables or databases from the backup, it is necessary to detect if there are any conflicts between the tables to be restored and the existing tables in the target cluster. If conflicts are found, an error should be reported in advance to avoid data integrity issues.
There was a problem hiding this comment.
Sometimes br restore full don't mean I realy want to resotre the entire cluster. In certain scenarios, I just want to restore multiple tables, but they are distributed across different databases. But neither br restore table nor br restore db supports regular expressions.
So, can you add a --force option to skip this check??
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Leavrth, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
ti-chi-bot
bot
added
needs-cherry-pick-release-5.3
3pointer
removed
needs-cherry-pick-release-5.3
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #45014 +/- ##
================================================
+ Coverage 73.2051% 73.2219% +0.0167%
================================================
Files 1270 1276 +6
Lines 390023 390745 +722
================================================
+ Hits 285517 286111 +594
- Misses 86192 86287 +95
- Partials 18314 18347 +33
Flags with carried forward coverage won't be shown. Click here to find out more.
|
What problem does this PR solve?
Issue Number: close #35744
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.