Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README: add badges and links #45159

Merged
merged 3 commits into from
Jul 7, 2023
Merged

README: add badges and links #45159

merged 3 commits into from
Jul 7, 2023

Conversation

ChenlingLu
Copy link
Contributor

@ChenlingLu ChenlingLu commented Jul 5, 2023 •
edited
Loading

Issue Number: ref None

What problem does this PR solve?

  1. Align the first div to center and make the TiDB logo clickable
  2. Add two website links
    a. Visit the Official Website -> https://www.pingcap.com/
    b. Try it Online -> https://play.tidbcloud.com/
  3. Add social media quick links
    a. TiDB Developer twitter account
    b. Forum
    c. Slack
    d. Stack Overflow
截屏2023-07-06 17 50 44

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ChenlingLu
Update badges in README.md
5e8df98 
- Align the title to center
- Add two website links
- Add quick links about social media
@ChenlingLu
Update README.md
1494630
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 5, 2023
@tiprow
Copy link

tiprow bot commented Jul 5, 2023

Hi @ChenlingLu. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 5, 2023
@ChenlingLu
Copy link
Contributor Author

@winkyao PTAL

@hawkingrei hawkingrei changed the title README.md: add badges and links README: add badges and links Jul 5, 2023
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 5, 2023
@hawkingrei hawkingrei added the skip-issue-check Indicates that a PR no need to check linked issue. label Jul 5, 2023
@ChenlingLu
Delete the link of PingCAP twitter account
f93068e 
Delete the link of pingcap twitter account
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 5, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 6, 2023

@ChenlingLu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-br-integration-test f93068e link true /test pull-br-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot
Copy link
Member

@ChenlingLu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-br-integration-test f93068e link true /test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tiprow
Copy link

tiprow bot commented Jul 6, 2023

@ChenlingLu: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ChenlingLu
Copy link
Contributor Author

/retest

@tiprow
Copy link

tiprow bot commented Jul 6, 2023

@ChenlingLu: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

winkyao
winkyao approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, winkyao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 7, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 7, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-05 02:57:53.977632859 +0000 UTC m=+172705.911266274: ☑️ agreed by hawkingrei.
  • 2023-07-07 02:33:13.507919061 +0000 UTC m=+40085.278257774: ☑️ agreed by winkyao.

@ti-chi-bot ti-chi-bot bot merged commit b95b979 into pingcap:master Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@winkyao winkyao winkyao approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChenlingLu @ti-chi-bot @hawkingrei @winkyao