Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ttl: Add TTLTimersSyncer to sync TTL meta to timers #45165

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

lcwangchao
Copy link
Collaborator

@lcwangchao lcwangchao commented Jul 5, 2023

What problem does this PR solve?

Issue Number: close #45164

What is changed and how it works?

TTLTimersSyncer is an struct to do synchronization to sync meta to timers. This PR is only a implement for TTLTimersSyncer but has not used it yet.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 5, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 5, 2023
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 5, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 5, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 5, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 5, 2023
@lcwangchao
Copy link
Collaborator Author

/retest

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 6, 2023

@lcwangchao: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-br-integration-test 09da325 link true /test pull-br-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lcwangchao
Copy link
Collaborator Author

/retest

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [YangKeao,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 6, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 6, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-05 06:42:31.591027011 +0000 UTC m=+186183.524660434: ☑️ agreed by YangKeao.
  • 2023-07-06 11:29:59.780390009 +0000 UTC m=+21078.661865956: ☑️ agreed by hawkingrei.

@ti-chi-bot ti-chi-bot bot merged commit 967699a into pingcap:master Jul 6, 2023
@lcwangchao lcwangchao deleted the ttl_syncer branch July 7, 2023 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add TTLTimersSyncer to sync TTL meta to timers
4 participants