Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txn: remove TxnContextProvider.SetTxnInfoSchema #45207

Merged

Conversation

lcwangchao
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #44361

What is changed and how it works?

Like #44362 , also remove SetTxnInfoSchema for TxnContextProvider because it is not used by any code

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 6, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 6, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, tiancaiamao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,tiancaiamao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 6, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 6, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-06 07:02:30.566197249 +0000 UTC m=+5029.447673192: ☑️ agreed by tiancaiamao.
  • 2023-07-06 07:39:31.17435598 +0000 UTC m=+7250.055831928: ☑️ agreed by hawkingrei.

@hawkingrei
Copy link
Member

/test all

@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 6, 2023
@ti-chi-bot ti-chi-bot bot merged commit 63f6b48 into pingcap:master Jul 6, 2023
@lcwangchao lcwangchao deleted the remove_provider_set_infoschema branch July 8, 2023 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

delete useless delete useless SetTxnInfoSchema in TxnManager
3 participants