Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: use gRPC prepared message to avoid duplicated encoding #45480

Merged
merged 4 commits into from
Jul 28, 2023
Merged

lightning: use gRPC prepared message to avoid duplicated encoding #45480

merged 4 commits into from
Jul 28, 2023

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Jul 20, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #45383

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

before

[2023/07/24 14:01:26.934 +08:00] [INFO] [local.go:1462] ["import engine success"] [uuid=faa8289d-3378-544f-8e7a-c12498f388d4] [size=108087902895] [kvs=100000000] [importedSize=108087902895] [importedCount=100000000]
[2023/07/24 14:01:26.935 +08:00] [INFO] [backend.go:353] ["import completed"] [engineTag=`test`.`usertable`:0] [engineUUID=faa8289d-3378-544f-8e7a-c12498f388d4] [retryCnt=0] [takeTime=3m41.016948476s] []
[2023/07/24 14:01:52.803 +08:00] [INFO] [local.go:1462] ["import engine success"] [uuid=bede5e32-334c-5343-8ef3-08a54938c5c3] [size=5499999973] [kvs=100000000] [importedSize=5499999973] [importedCount=100000000]
[2023/07/24 14:01:52.804 +08:00] [INFO] [backend.go:353] ["import completed"] [engineTag=`test`.`usertable`:-1] [engineUUID=bede5e32-334c-5343-8ef3-08a54938c5c3] [retryCnt=0] [takeTime=23.40315731s] []
[2023/07/24 14:01:53.497 +08:00] [INFO] [import.go:515] ["the whole procedure completed"] [takeTime=14m38.509928185s] []

after

[2023/07/24 14:49:10.305 +08:00] [INFO] [local.go:1462] ["import engine success"] [uuid=faa8289d-3378-544f-8e7a-c12498f388d4] [size=108087902895] [kvs=100000000] [importedSize=108087902895] [importedCount=100000000]
[2023/07/24 14:49:10.306 +08:00] [INFO] [backend.go:353] ["import completed"] [engineTag=`test`.`usertable`:0] [engineUUID=faa8289d-3378-544f-8e7a-c12498f388d4] [retryCnt=0] [takeTime=2m54.358068332s] []
[2023/07/24 14:49:31.263 +08:00] [INFO] [local.go:1462] ["import engine success"] [uuid=bede5e32-334c-5343-8ef3-08a54938c5c3] [size=5499999973] [kvs=100000000] [importedSize=5499999973] [importedCount=100000000]
[2023/07/24 14:49:31.264 +08:00] [INFO] [backend.go:353] ["import completed"] [engineTag=`test`.`usertable`:-1] [engineUUID=bede5e32-334c-5343-8ef3-08a54938c5c3] [retryCnt=0] [takeTime=18.383461449s] []
[2023/07/24 14:49:31.964 +08:00] [INFO] [import.go:511] ["the whole procedure completed"] [takeTime=13m48.139963409s] []

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@lance6716
lightning: use gRPC prepared message to avoid duplicated encoding
a264c43 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 20, 2023
@lance6716
Copy link
Contributor Author

/test pull-br-integration-test

@tiprow
Copy link

tiprow bot commented Jul 20, 2023

Hi @lance6716. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiprow
Copy link

tiprow bot commented Jul 20, 2023

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Jul 20, 2023 •
edited
Loading

Codecov Report

Merging #45480 (b0effd9) into master (7a65395) will increase coverage by 0.0574%.
Report is 1 commits behind head on master.
The diff coverage is 77.7777%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #45480        +/-   ##
================================================
+ Coverage   73.2266%   73.2840%   +0.0574%     
================================================
  Files          1270       1273         +3     
  Lines        390037     390954       +917     
================================================
+ Hits         285611     286507       +896     
- Misses        86129      86144        +15     
- Partials      18297      18303         +6
Flag Coverage Δ
integration 78.1388% <ø> (?)
unit 73.2756% <77.7777%> (+0.0490%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0417% <ø> (-0.0109%) ⬇️
br 52.1373% <77.7777%> (-0.0139%) ⬇️

@lance6716
fix UT
f508148 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
Copy link
Contributor Author

/test pull-br-integration-test

@tiprow
Copy link

tiprow bot commented Jul 24, 2023

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lance6716
fix bazel
d2ddb74 
Signed-off-by: lance6716 <lance6716@gmail.com>
@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Jul 24, 2023
@lance6716
Copy link
Contributor Author

/test pull-br-integration-test

@tiprow
Copy link

tiprow bot commented Jul 24, 2023

@lance6716: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lance6716 lance6716 changed the title [WIP]lightning: use gRPC prepared message to avoid duplicated encoding lightning: use gRPC prepared message to avoid duplicated encoding Jul 24, 2023
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 24, 2023
D3Hunter
D3Hunter approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@D3Hunter D3Hunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, except that prepared msg is an experimental feature

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 25, 2023
GMHDBJD
GMHDBJD approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, GMHDBJD

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 27, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 27, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-25 10:47:15.12008319 +0000 UTC m=+264977.714614162: ☑️ agreed by D3Hunter.
  • 2023-07-27 06:27:55.268155618 +0000 UTC m=+422217.862686592: ☑️ agreed by GMHDBJD.

@lance6716
Copy link
Contributor Author

/retest

1 similar comment
@lance6716
Copy link
Contributor Author

/retest

@lance6716 lance6716 mentioned this pull request Jul 27, 2023
Closed
@hawkingrei
Copy link
Member

/retest

@lance6716
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 50e4911 into pingcap:master Jul 28, 2023
4 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@D3Hunter D3Hunter D3Hunter approved these changes

@GMHDBJD GMHDBJD GMHDBJD approved these changes

Assignees
No one assigned
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lightning use grpc PreparedMsg to avoid duplicate encoding
4 participants
@lance6716 @hawkingrei @D3Hunter @GMHDBJD