Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain: Add new item in scan context #45543

Merged
merged 10 commits into from
Aug 4, 2023
Merged

Explain: Add new item in scan context #45543

merged 10 commits into from
Aug 4, 2023

Conversation

hongyunyan
Copy link
Contributor

@hongyunyan hongyunyan commented Jul 25, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #39273

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/invalid-title do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 25, 2023
@tiprow
Copy link

tiprow bot commented Jul 25, 2023

Hi @hongyunyan. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 2, 2023
@hongyunyan
Copy link
Contributor Author

/rebuild

@hongyunyan
Copy link
Contributor Author

/build

@hongyunyan
Copy link
Contributor Author

/rerun

@hongyunyan
Copy link
Contributor Author

/retest

@tiprow
Copy link

tiprow bot commented Aug 2, 2023

@hongyunyan: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 2, 2023
@hongyunyan
Copy link
Contributor Author

/retest

@tiprow
Copy link

tiprow bot commented Aug 3, 2023

@hongyunyan: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hongyunyan
Copy link
Contributor Author

/retest

@tiprow
Copy link

tiprow bot commented Aug 4, 2023

@hongyunyan: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hawkingrei
Copy link
Member

/test all

@hawkingrei
Copy link
Member

/retest

@codecov
Copy link

codecov bot commented Aug 4, 2023 •
edited
Loading

Codecov Report

Merging #45543 (b53d6a1) into master (1e73eee) will increase coverage by 0.0269%.
Report is 16 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #45543        +/-   ##
================================================
+ Coverage   73.3385%   73.3655%   +0.0269%     
================================================
  Files          1271       1275         +4     
  Lines        392949     393760       +811     
================================================
+ Hits         288183     288884       +701     
- Misses        86395      86471        +76     
- Partials      18371      18405        +34
Flag Coverage Δ
integration 78.1388% <ø> (?)
unit 73.3572% <100.0000%> (+0.0187%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0359% <ø> (ø)
br 52.0753% <ø> (+0.0560%) ⬆️

@hongyunyan
Copy link
Contributor Author

/test build

@tiprow
Copy link

tiprow bot commented Aug 4, 2023

@hongyunyan: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hongyunyan
Copy link
Contributor Author

/retest

@tiprow
Copy link

tiprow bot commented Aug 4, 2023

@hongyunyan: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xzhangxian1008
Copy link
Contributor

/retest

@tiprow
Copy link

tiprow bot commented Aug 4, 2023

@xzhangxian1008: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hongyunyan
Copy link
Contributor Author

/retest

@tiprow
Copy link

tiprow bot commented Aug 4, 2023

@hongyunyan: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hongyunyan
Copy link
Contributor Author

/run-check_dev_2

@hongyunyan
Copy link
Contributor Author

/run-idc-jenkins-ci-tidb/check_dev_2

@hongyunyan
Copy link
Contributor Author

/retest

@tiprow
Copy link

tiprow bot commented Aug 4, 2023

@hongyunyan: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 4, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: breezewish, SeaRise

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 4, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-02 12:25:26.285315686 +0000 UTC m=+274610.227664218: ☑️ agreed by breezewish.
  • 2023-08-04 09:06:14.693255056 +0000 UTC m=+435458.635603577: ☑️ agreed by SeaRise.

@hongyunyan
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 4, 2023

@hongyunyan: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hongyunyan hongyunyan changed the title Add new item in scan context Explain: Add new item in scan context Aug 4, 2023
@ti-chi-bot ti-chi-bot bot merged commit 3fa6b94 into pingcap:master Aug 4, 2023
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breezewish breezewish breezewish approved these changes

@SeaRise SeaRise SeaRise approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hongyunyan @hawkingrei @xzhangxian1008 @breezewish @SeaRise