Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: enable fieldalignment #45766

Merged
merged 4 commits into from
Aug 2, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Aug 2, 2023

What problem does this PR solve?

Issue Number: ref #40786

Problem Summary:

What is changed and how it works?

/Users/weizhenwang/devel/opensource/tidb/statistics/analyze.go:70:21: struct with 80 pointer bytes could be 40
/Users/weizhenwang/devel/opensource/tidb/statistics/analyze_jobs.go:23:17: struct with 160 pointer bytes could be 152
/Users/weizhenwang/devel/opensource/tidb/statistics/analyze_jobs.go:35:22: struct with 40 pointer bytes could be 24
/Users/weizhenwang/devel/opensource/tidb/statistics/builder.go:31:20: struct with 56 pointer bytes could be 16
/Users/weizhenwang/devel/opensource/tidb/statistics/cmsketch.go:55:15: struct with 32 pointer bytes could be 8
/Users/weizhenwang/devel/opensource/tidb/statistics/cmsketch.go:82:17: struct with 16 pointer bytes could be 8
/Users/weizhenwang/devel/opensource/tidb/statistics/column.go:37:13: struct with 256 pointer bytes could be 184
/Users/weizhenwang/devel/opensource/tidb/statistics/debugtrace.go:33:24: struct with 64 pointer bytes could be 32
/Users/weizhenwang/devel/opensource/tidb/statistics/debugtrace.go:42:27: struct with 112 pointer bytes could be 32
/Users/weizhenwang/devel/opensource/tidb/statistics/debugtrace.go:178:23: struct with 16 pointer bytes could be 8
/Users/weizhenwang/devel/opensource/tidb/statistics/debugtrace.go:203:29: struct with 56 pointer bytes could be 48
/Users/weizhenwang/devel/opensource/tidb/statistics/debugtrace.go:272:23: struct of size 40 could be 32
/Users/weizhenwang/devel/opensource/tidb/statistics/debugtrace.go:331:20: struct with 72 pointer bytes could be 56
/Users/weizhenwang/devel/opensource/tidb/statistics/feedback.go:97:23: struct with 16 pointer bytes could be 8
/Users/weizhenwang/devel/opensource/tidb/statistics/feedback.go:389:21: struct with 40 pointer bytes could be 24
/Users/weizhenwang/devel/opensource/tidb/statistics/fmsketch.go:29:15: struct with 40 pointer bytes could be 24
/Users/weizhenwang/devel/opensource/tidb/statistics/histogram.go:49:16: struct with 80 pointer bytes could be 48
/Users/weizhenwang/devel/opensource/tidb/statistics/index.go:40:12: struct with 248 pointer bytes could be 184
/Users/weizhenwang/devel/opensource/tidb/statistics/merge_worker.go:79:29: struct with 72 pointer bytes could be 56
/Users/weizhenwang/devel/opensource/tidb/statistics/row_sampler.go:67:29: struct with 48 pointer bytes could be 24
/Users/weizhenwang/devel/opensource/tidb/statistics/row_sampler.go:121:23: struct with 128 pointer bytes could be 88
/Users/weizhenwang/devel/opensource/tidb/statistics/sample.go:40:17: struct with 96 pointer bytes could be 88
/Users/weizhenwang/devel/opensource/tidb/statistics/sample.go:73:23: struct with 48 pointer bytes could be 32
/Users/weizhenwang/devel/opensource/tidb/statistics/sample.go:97:22: struct with 88 pointer bytes could be 32
/Users/weizhenwang/devel/opensource/tidb/statistics/sample.go:216:20: struct with 104 pointer bytes could be 64
/Users/weizhenwang/devel/opensource/tidb/statistics/selectivity.go:45:16: struct with 32 pointer bytes could be 8
/Users/weizhenwang/devel/opensource/tidb/statistics/table.go:66:12: struct with 96 pointer bytes could be 64
/Users/weizhenwang/devel/opensource/tidb/statistics/table.go:80:24: struct with 48 pointer bytes could be 24
/Users/weizhenwang/devel/opensource/tidb/statistics/table.go:108:15: struct with 40 pointer bytes could be 32
/Users/weizhenwang/devel/opensource/tidb/statistics/table.go:127:23: struct with 32 pointer bytes could be 16
/Users/weizhenwang/devel/opensource/tidb/statistics/table.go:444:21: struct with 32 pointer bytes could be 8

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Aug 2, 2023
@hawkingrei hawkingrei requested a review from chrysan August 2, 2023 09:32
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #45766 (3cd9c86) into master (62d0271) will increase coverage by 0.0265%.
Report is 1 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #45766        +/-   ##
================================================
+ Coverage   73.3357%   73.3623%   +0.0265%     
================================================
  Files          1271       1274         +3     
  Lines        392950     393627       +677     
================================================
+ Hits         288173     288774       +601     
- Misses        86401      86433        +32     
- Partials      18376      18420        +44     
Flag Coverage Δ
integration 78.1388% <ø> (?)
unit 73.3541% <100.0000%> (+0.0183%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0359% <ø> (ø)
br 52.0213% <ø> (+0.0083%) ⬆️

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 2, 2023
@hawkingrei hawkingrei requested a review from winoros August 2, 2023 10:45
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrysan, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 2, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 2, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-02 10:40:49.839503608 +0000 UTC m=+268333.781852139: ☑️ agreed by chrysan.
  • 2023-08-02 10:46:30.857280381 +0000 UTC m=+268674.799628911: ☑️ agreed by winoros.

@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 1e73eee into pingcap:master Aug 2, 2023
7 of 9 checks passed
@hawkingrei hawkingrei deleted the enable_fieldment_for_all branch August 3, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants