Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: support /upgrade/start and upgrade/finish APIs #45887

Merged
merged 7 commits into from
Aug 16, 2023

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Aug 8, 2023

What problem does this PR solve?

Issue Number: close #45886

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@zimulala zimulala requested a review from a team as a code owner August 8, 2023 02:30
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 8, 2023
@tiprow
Copy link

tiprow bot commented Aug 8, 2023

Hi @zimulala. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

server/http_handler.go Outdated Show resolved Hide resolved
@zimulala zimulala changed the title *: support /upgrade/start and upgrade/finish APIs *: support /upgrade/start and upgrade/finish APIs Aug 8, 2023
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #45887 (521fe54) into master (de30804) will decrease coverage by 0.6074%.
Report is 89 commits behind head on master.
The diff coverage is 66.6666%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #45887        +/-   ##
================================================
- Coverage   73.3404%   72.7330%   -0.6074%     
================================================
  Files          1274       1304        +30     
  Lines        393217     400657      +7440     
================================================
+ Hits         288387     291410      +3023     
- Misses        86445      90767      +4322     
- Partials      18385      18480        +95     
Flag Coverage Δ
integration 25.6196% <5.5555%> (?)
unit 73.4140% <66.6666%> (+0.0736%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0656% <ø> (+0.0297%) ⬆️
br 47.7968% <ø> (-4.2468%) ⬇️

@pingcap pingcap deleted a comment from ti-chi-bot bot Aug 8, 2023
@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Aug 8, 2023
@pingcap pingcap deleted a comment from ti-chi-bot bot Aug 15, 2023
@pingcap pingcap deleted a comment from tiprow bot Aug 15, 2023
@zimulala
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 15, 2023
@easonn7
Copy link

easonn7 commented Aug 16, 2023

/approve

there is no variable behavior change.

@ti-chi-bot ti-chi-bot bot added the approved label Aug 16, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: easonn7, hawkingrei, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 16, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 16, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-15 08:10:47.301658272 +0000 UTC m=+618611.850674244: ☑️ agreed by hawkingrei.
  • 2023-08-16 09:23:02.253533023 +0000 UTC m=+709346.802549010: ☑️ agreed by tangenta.

@hawkingrei hawkingrei removed the request for review from a team August 16, 2023 09:23
@ti-chi-bot ti-chi-bot bot merged commit e1a017c into pingcap:master Aug 16, 2023
3 of 9 checks passed
zimulala added a commit to zimulala/tidb that referenced this pull request Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement /upgrade/start and upgrade/finish APIs
4 participants