*: get nil in the LFU's onEvict #45949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note-none
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #45949 +/- ##
================================================
- Coverage 74.7799% 72.7201% -2.0598%
================================================
Files 1293 1300 +7
Lines 397910 400919 +3009
================================================
- Hits 297557 291549 -6008
- Misses 80985 90956 +9971
+ Partials 19368 18414 -954
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/test all |
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
hawkingrei
force-pushed
the
lfu_onevict
branch
from
ac5a8ce
to
88660ef
Compare
winoros
reviewed
Aug 10, 2023
qw4990
reviewed
Aug 10, 2023
hawkingrei
force-pushed
the
lfu_onevict
branch
from
df03cc6
to
daae23c
Compare
qw4990
approved these changes
Aug 10, 2023
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
winoros
approved these changes
Aug 10, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qw4990, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
/retest |
2 similar comments
|
/retest |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #45946
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.