executor: Fix coroutine leak after kill remote connection (#46035) #46063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot
added
ok-to-test
ti-chi-bot
bot
added
release-note-none
12 tasks
ti-chi-bot
bot
added
size/S
ti-chi-bot
added
the
cherry-pick-approved
Signed-off-by: Ping Yu <yuping@pingcap.com>
|
/invite |
|
/cherry-pick-invite |
|
@pingyu Please accept the invitation then you can push to the cherry-pick pull requests. |
ti-chi-bot
bot
added
size/M
|
/test unit-test |
hawkingrei
approved these changes
Aug 17, 2023
ti-chi-bot
bot
added
needs-1-more-lgtm
tangenta
approved these changes
Aug 17, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #46035
What problem does this PR solve?
Issue Number: close #46034
Problem Summary: Coroutine leak after kill remote connection.
What is changed and how it works?
Close
respof coprocessor request. Otherwise the coprocessor will be blocked on therespChan.Check List
Tests
Run the same test in issue, the coroutine count was stable, and no OOM occurred.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.