Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: remove some unnecessary estimation code #46498

Merged
merged 4 commits into from
Aug 30, 2023

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Aug 30, 2023

What problem does this PR solve?

Issue Number: ref #46358

Problem Summary: planner: remove some unnecessary estimation code

What is changed and how it works?

planner: remove some unnecessary estimation code

image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 30, 2023
@tiprow
Copy link

tiprow bot commented Aug 30, 2023

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qw4990 qw4990 added sig/planner SIG: Planner epic/cardinality-estimation the optimizer cardinality estimation labels Aug 30, 2023
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 30, 2023
@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Aug 30, 2023
Copy link
Member

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 30, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 30, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-30 06:34:28.962810807 +0000 UTC m=+1908833.511826793: ☑️ agreed by hawkingrei.
  • 2023-08-30 06:44:21.875754442 +0000 UTC m=+1909426.424770429: ☑️ agreed by hi-rustin.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei, hi-rustin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [AilinKid,hawkingrei,hi-rustin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #46498 (15a7f87) into master (d1483b8) will decrease coverage by 0.6633%.
Report is 6 commits behind head on master.
The diff coverage is 66.6666%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #46498        +/-   ##
================================================
- Coverage   73.3755%   72.7123%   -0.6633%     
================================================
  Files          1303       1323        +20     
  Lines        394509     400708      +6199     
================================================
+ Hits         289473     291364      +1891     
- Misses        86640      90893      +4253     
- Partials      18396      18451        +55     
Flag Coverage Δ
integration 25.6968% <44.4444%> (?)
unit 73.3880% <55.5555%> (+0.0124%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0638% <ø> (ø)
br 48.0297% <ø> (-4.3292%) ⬇️

@tiprow
Copy link

tiprow bot commented Aug 30, 2023

@qw4990: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tiprow_fast_test 15a7f87 link true /test tiprow_fast_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit a43d267 into pingcap:master Aug 30, 2023
13 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved epic/cardinality-estimation the optimizer cardinality estimation lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants